Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] damageItem property is an empty string when the damageType is "Weapon" for console matches #949

Open
serkanbal opened this issue Jul 1, 2024 · 0 comments

Comments

@serkanbal
Copy link

serkanbal commented Jul 1, 2024

Bug Description
For FinishingDamageDto, when the damageType is "Weapon", the damageItem property is usually an empty string for console matches. The only exception I've seen so far is Neon's ultimate. When a player is killed by Neon's ultimate, the damageType is "Weapon" and the damageItem is correctly displayed as "95336AE4-45D4-1032-CFAF-6BAD01910607".

Problem Description
The damageItem property is usually an empty string when the damageType is an empty string. This causes us to not be able to display and analyze which damage source was used to kill the enemy player.

Expected Result
The damageItem property should be populated by the uuid of the damageItem.

Actual Result
The damageItem is returned as an empty string ("").

Developer Impact
Our implementation depends on the field to be populated and returned correctly all the time. As a result our features such as "Weapon Stats" are not displayed correctly. This, in return, triggers complaints from our users.

  • Frequency: Every API call.
  • Severity: Moderate. Some features of the app are not functioning correctly.

Player Impact
Users are unable to see which gun was used for their kills or when they are killed.

  • Frequency: Every time the user launches our app.
  • Severity: Moderate. We are unable to provide the complete stats of users. Users are unable to check damageItem related features such as "Weapon Stats" correctly.

Repro Steps
Call the /val/match/console/v1/matches/{matchId} with any valid console matchId.

Issue Comments
Might want to leave this as instructions for any replies to your issue:

If you're also experiencing this issue please add any additional context that is useful, the developer impact to yourself, and the player impact to your users. As an example, if spectator-v4 isn't working it might affect a scouting site, but it could also affect a mobile app or site to share replays. Give the context on how this issue affects your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants