Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] console_competitive missing from /val/match/console/v1/recent-matches/by-queue/{queue} #952

Open
PenguinDevs opened this issue Jul 5, 2024 · 4 comments
Labels
api: val-console-match-v1 on hold: escalated to team This issue has been escalated to the team that owns the service. scope: val type: bug report

Comments

@PenguinDevs
Copy link

Bug Description
The competitive console queue is missing from /val/match/console/v1/recent-matches/by-queue/{queue} the list of console queue types available.

This is similar to #942, except this bug report is for the console competitive queue.

Problem Description
Other queue types for console such as console_unrated, console_swiftplay, console_hurm, console_deathmatch are available for the /val/match/console/v1/recent-matches/by-queue/{queue} endpoint. But because the console_competitive is a new queue, it is missing from the initial release of the console match lists endpoint.

Expected Result
To be able to retrieve a list of match ids for the console_competitive queue from /val/match/console/v1/recent-matches/by-queue/{queue}

Actual Result
When attempting to GET https://na.api.riotgames.com/val/match/console/v1/recent-matches/by-queue/console_competitive, the response received is {"status":{"message":"Bad request - Path parameter 'queue' must be one of [console_unrated, console_swiftplay, console_hurm, console_deathmatch]. Invalid value 'console_competitive' given.","status_code":400}}

Developer Impact
Inability to fetch recent console competitive games in the past 10 minutes through a single request. The alternatives are to instead seek for games of this queue type through the player's console match lists /val/match/console/v1/matches/{matchId} for a large amount of players, and thus numerous API calls.

Player Impact
Some apps may need to omit the console competitive queue type in features that for example require a collation of many valorant matches in a particular episode or act.

Preconditions
None.

Repro Steps
curl -H 'X-Riot-Token: YOUR TOKEN' 'https://{shard}.api.riotgames.com/val/match/console/v1/recent-matches/by-queue/console_competitive'

Issue Comments
If you're also experiencing this issue please add any additional context that is useful, the developer impact to yourself, and the player impact to your users. As an example, if spectator-v4 isn't working it might affect a scouting site, but it could also affect a mobile app or site to share replays. Give the context on how this issue affects your project.

@PenguinDevs PenguinDevs changed the title [BUG] console_competitive missing from /val/match/console/v1/recent-matches/by-queue/{queue} [BUG] console_competitive missing from /val/match/console/v1/recent-matches/by-queue/{queue} Jul 13, 2024
@tisbells tisbells added api: val-console-match-v1 on hold: escalated to team This issue has been escalated to the team that owns the service. labels Aug 6, 2024
@tisbells
Copy link
Contributor

tisbells commented Aug 6, 2024

Hi - We're checking in on this.

@PenguinDevs
Copy link
Author

Hello, are there any updates on this?

@raimannma
Copy link

It's fixed already!

@PenguinDevs
Copy link
Author

I should've checked before sending that, ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: val-console-match-v1 on hold: escalated to team This issue has been escalated to the team that owns the service. scope: val type: bug report
Projects
None yet
Development

No branches or pull requests

3 participants