Merge pull request #99 from baszalmstra/ruff

feat(ci): add format, lint and testing and remove handling of REQUIRE_OPENGL and REQUIRE_GL magic values in deps

Author: traversaro

.flake8

@@ -0,0 +1,33 @@
+name: CI
+
+on:
+  push:
+    branches: [ main, master ]
+  pull_request:
+    branches: [ main, master ]
+
+jobs:
+  test:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+      fail-fast: false
+
+    steps:
+    - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+
+    - name: Setup Pixi
+      uses: prefix-dev/setup-pixi@28eb668aafebd9dede9d97c4ba1cd9989a4d0004 # v0.9.2
+      with:
+        pixi-version: latest
+        cache: true
+
+    - name: Check formatting
+      run: pixi run fmt-check
+
+    - name: Run linter
+      run: pixi run lint-check
+
+    - name: Run tests
+      run: pixi run test

.github/workflows/ci.yml

@@ -0,0 +1,17 @@
+on:
+  push:
+    branches: [ main, master ]
+  pull_request:
+
+name: Security
+
+permissions: read-all
+
+jobs:
+  ensure-pinned-actions:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5
+      - name: Ensure SHA pinned actions
+        uses: zgosalvez/github-actions-ensure-sha-pinned-actions@9e9574ef04ea69da568d6249bd69539ccc704e74 # v4

.github/workflows/enforce-sha.yml

@@ -9,8 +9,10 @@ version = "0.1.0"
 test = "pytest vinca/"
 
 # Code quality
-format = "black --safe --quiet ."
-lint = "flake8 vinca/"
+fmt = "ruff format ."
+fmt-check = "ruff format --check ."
+lint = "ruff check --fix ."
+lint-check = "ruff check ."
 
 [dependencies]
 python = ">=3.14.0,<3.15"
@@ -28,8 +30,7 @@ license-expression = ">=30.0.0"
 
 # Development dependencies
 pytest = "*"
-black = "*"
-flake8 = "*"
+ruff = "*"
 
 [pypi-dependencies]
 vinca = { path = ".", editable = true}

pixi.lock

@@ -0,0 +1,12 @@
+line-length = 88
+target-version = "py37"
+
+[lint]
+# Ignore rules that were excluded in .flake8:
+# D104: Missing docstring in public package
+# E501: Line too long (handled by line-length setting)
+ignore = ["D104", "D100", "E501"]
+
+[lint.extend-per-file-ignores]
+# Exclude tests/data/* from all checks
+"tests/data/*" = ["ALL"]

pixi.toml

@@ -110,7 +110,6 @@ def get_depends(self, pkg, ignore_pkgs=None):
 
     def get_released_repo(self, pkg_name):
         if self.snapshot and pkg_name in self.snapshot:
-
             # In the case of snapshot, for rosdistro_additional_recipes
             # we also support a 'rev' field, so depending on what is available
             # we return either the tag or the rev, and the third argument is either 'rev' or 'tag'

ruff.toml

@@ -428,7 +428,6 @@ def get_full_tree():
 
 
 def main():
-
     args = parse_command_line(sys.argv)
 
     full_tree = get_full_tree()

vinca/distro.py

@@ -356,8 +356,6 @@ def build_win_pipeline(stages, trigger_branch, outfile="win.yml", azure_template
         with open(".scripts/build_win.bat", "r") as fi:
             script = lu(fi.read())
 
-    jobs = []
-    job_names = []
     prev_batch_keys = []
     for i, s in enumerate(stages):
         stage_name = f"stage_{i}"

vinca/generate_azure.py

@@ -149,9 +149,7 @@ def convert_to_spdx_license(
             # Split by comma and process each part
             # Filter out empty strings from malformed input
             # (trailing/double commas)
-            parts = [
-                part.strip() for part in lic_str.split(",") if part.strip()
-            ]
+            parts = [part.strip() for part in lic_str.split(",") if part.strip()]
             sub_licenses = []
             seen_sub = set()
             for part in parts: