Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Quoting issues #641

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

devanshkansagra
Copy link
Contributor

@devanshkansagra devanshkansagra commented Oct 23, 2024

Acceptance Criteria fulfillment

  • Recursively Quoting of messages
  • Multiple quoting of messages

Fixes #640

Video/Screenshots

Screencast.from.04-11-24.10.14.00.PM.IST.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-641/ after approval.

@devanshkansagra devanshkansagra marked this pull request as ready for review November 4, 2024 17:04
@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, I have implemented recursive and multiple quoting in EmbeddedChat, can you please review it?

@devanshkansagra
Copy link
Contributor Author

Let me know once you check the deployment of this pull request

@Spiral-Memory
Copy link
Collaborator

Sure @devanshkansagra

@devanshkansagra
Copy link
Contributor Author

Ok

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, could you please approve to test so that can come to know whether the changes I made in this pr gets deployed properly and we can prevent the situation before we faced and we had to revert the changes.

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test ! Review pending

@devanshkansagra
Copy link
Contributor Author

Okay

@devanshkansagra
Copy link
Contributor Author

@Spiral-Memory, it is again facing the same error in deployment like earlier, but I am also confused that it is working properly in my local development environment but it is failing in the production build

@Spiral-Memory
Copy link
Collaborator

But as far as i can see, build succeeded

@devanshkansagra
Copy link
Contributor Author

yea build is succeded but when I checked the logs, it issues is in the build part only

@devanshkansagra
Copy link
Contributor Author

image

@Spiral-Memory
Copy link
Collaborator

Share me the error

@devanshkansagra
Copy link
Contributor Author

the above image is the error

@devanshkansagra
Copy link
Contributor Author

preview.mjs:401 TypeError: Cannot read properties of undefined (reading '0')
at Attachment (180.a44f4e00.iframe.bundle.js:1:205154)
at Ch (preview.mjs:401:1)
at ck (preview.mjs:401:1)
at bk (preview.mjs:401:1)
at ak (preview.mjs:401:1)
at Tj (preview.mjs:401:1)
at Lj (preview.mjs:401:1)
at preview.mjs:401:1
at exports.unstable_runWithPriority (preview.mjs:401:1)
at gg (preview.mjs:401:1)

@devanshkansagra
Copy link
Contributor Author

the above is the console error

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, can you please approve again to test, coz I have added some checks

Copy link
Collaborator

@Spiral-Memory Spiral-Memory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to test ! Review pending

@devanshkansagra
Copy link
Contributor Author

it is now working well

@devanshkansagra
Copy link
Contributor Author

devanshkansagra commented Nov 6, 2024

you can test it

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, I have tested from my side, it is working well, you can also test and review the code and output

@Spiral-Memory
Copy link
Collaborator

@devanshkansagra Please resolve the conflicts

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, can you review the pr and also approve to test after to check whether everything is well

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, you can test the deployment and suggest any changes

@Spiral-Memory
Copy link
Collaborator

I'll test / review it and let you know

@devanshkansagra
Copy link
Contributor Author

Hey @Spiral-Memory, Currently do not review or merge it coz I found a bug due to which the thread messages are not sended properly. You can check the pr deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Message quoting issues
2 participants