fix: deno runtime controller not handling undefined child process reference correctly

d-gubert · d-gubert · commit 7d6647fb7bf4 · 2024-11-10T15:42:31.000-03:00
RocketChat/Rocket.Chat#33494
diff --git a/src/server/runtime/deno/AppsEngineDenoRuntime.ts b/src/server/runtime/deno/AppsEngineDenoRuntime.ts
@@ -215,7 +215,7 @@ export class DenoRuntimeSubprocessController extends EventEmitter {
 
     public async getStatus(): Promise<AppStatus> {
         // If the process has been terminated, we can't get the status
-        if (this.deno.exitCode !== null) {
+        if (!this.deno || this.deno.exitCode !== null) {
             return AppStatus.UNKNOWN;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ export class DenoRuntimeSubprocessController extends EventEmitter {`
`215`	`215`
`216`	`216`	`public async getStatus(): Promise<AppStatus> {`
`217`	`217`	`// If the process has been terminated, we can't get the status`
`218`		`- if (this.deno.exitCode !== null) {`
	`218`	`+ if (!this.deno \|\| this.deno.exitCode !== null) {`
`219`	`219`	`return AppStatus.UNKNOWN;`
`220`	`220`	`}`
`221`	`221`