Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL is not defined in #714

Open
RegisHubelia opened this issue Jan 25, 2024 · 2 comments · May be fixed by #738
Open

URL is not defined in #714

RegisHubelia opened this issue Jan 25, 2024 · 2 comments · May be fixed by #738

Comments

@RegisHubelia
Copy link

RegisHubelia commented Jan 25, 2024 •
edited
Loading

Server Version: 6.5.3
apps-engine: 1.41.0

Hi,

I am getting the following in the Apps.clickup on the server side:

2024-01-25T15:55:45.852447688-05:00     at OAuth2Client.<anonymous> (/app/bundle/programs/server/npm/node_modules/@rocket.chat/apps-engine/server/oauth2/OAuth2Client.js:79:25)
2024-01-25T15:55:45.852454831-05:00     at Generator.next (<anonymous>)
2024-01-25T15:55:45.852461203-05:00     at fulfilled (/app/bundle/programs/server/npm/node_modules/@rocket.chat/apps-engine/server/oauth2/OAuth2Client.js:5:58)
2024-01-25T15:55:45.852465552-05:00     at VM2 Wrapper.apply (/app/bundle/programs/server/npm/node_modules/vm2/lib/bridge.js:485:11)
2024-01-25T15:55:45.852469059-05:00     at /app/bundle/programs/server/npm/node_modules/meteor/promise/node_modules/meteor-promise/fiber_pool.js:43:40```

Seems like the new URL is causing issue in the file, not 100% sure why.
@JeffreytheCoder
Copy link

I'm getting the same issue in Github App: #139

@JeffreytheCoder
Copy link

@RegisHubelia I solved this issue by importing URL from url module in OAuth2Client.js.

Although URL should be a global variable in Node.js environment, it appears that projects with older versions of Node, particularly <= v14, share the same issue. For examples:
npm/npm-registry-fetch#49
fent/node-ytdl-core#859

@JeffreytheCoder JeffreytheCoder linked a pull request Mar 13, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX] Import url module in OAuth2Client JeffreytheCoder/Rocket.Chat.Apps-engine
2 participants
@RegisHubelia @JeffreytheCoder