Skip to content

Commit 4381cd3

Browse files
authored
Merge branch 'develop' into fix-links
2 parents c9b0ebb + 10faaf9 commit 4381cd3

File tree

651 files changed

+27260
-17459
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

651 files changed

+27260
-17459
lines changed

.github/workflows/cd.yml

+3-7
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
steps:
1919
- uses: actions/setup-node@v2
2020
with:
21-
node-version: "14.17.6"
21+
node-version: "14.21.3"
2222
- uses: actions/checkout@v2
2323
- name: Turbo Cache
2424
id: turbo-cache
@@ -44,8 +44,6 @@ jobs:
4444
name: storybooks
4545
path: |
4646
packages/fuselage/storybook-static
47-
packages/fuselage-ui-kit/storybook-static
48-
packages/uikit-playground/build
4947
packages/onboarding-ui/storybook-static
5048
packages/layout/storybook-static
5149
- if: github.ref == 'refs/heads/master'
@@ -71,7 +69,7 @@ jobs:
7169
steps:
7270
- uses: actions/setup-node@v2
7371
with:
74-
node-version: "14.17.6"
72+
node-version: "14.21.3"
7573
registry-url: "https://registry.npmjs.org"
7674
scope: "@rocket.chat"
7775
- uses: actions/checkout@v2
@@ -125,10 +123,8 @@ jobs:
125123
name: docs
126124
path: .
127125
- run: |
128-
rm -rf "fuselage/${{ needs.build-and-test.outputs.branch-name }}" "layout/${{ needs.build-and-test.outputs.branch-name }}" "uikit-playground/${{ needs.build-and-test.outputs.branch-name }}" "fuselage-ui-kit/${{ needs.build-and-test.outputs.branch-name }}" "onboarding-ui/${{ needs.build-and-test.outputs.branch-name }}"
126+
rm -rf "fuselage/${{ needs.build-and-test.outputs.branch-name }}" "layout/${{ needs.build-and-test.outputs.branch-name }}" "onboarding-ui/${{ needs.build-and-test.outputs.branch-name }}"
129127
mv -v "packages/fuselage/storybook-static" "fuselage/${{ needs.build-and-test.outputs.branch-name }}"
130-
mv -v "packages/uikit-playground/build" "uikit-playground/${{ needs.build-and-test.outputs.branch-name }}"
131-
mv -v "packages/fuselage-ui-kit/storybook-static" "fuselage-ui-kit/${{ needs.build-and-test.outputs.branch-name }}"
132128
mv -v "packages/onboarding-ui/storybook-static" "onboarding-ui/${{ needs.build-and-test.outputs.branch-name }}"
133129
mv -v "packages/layout/storybook-static" "layout/${{ needs.build-and-test.outputs.branch-name }}"
134130
rm -rf packages

.github/workflows/ci-pr-closed.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
- uses: actions/checkout@v2
1414
with:
1515
ref: gh-pages
16-
- run: rm -rf "fuselage/${{ github.event.number }}" "layout/${{ github.event.number }}" "fuselage-ui-kit/${{ github.event.number }}" "uikit-playground/${{ github.event.number }}" "onboarding-ui/${{ github.event.number }}"
16+
- run: rm -rf "fuselage/${{ github.event.number }}" "layout/${{ github.event.number }}" "onboarding-ui/${{ github.event.number }}"
1717
- uses: crazy-max/ghaction-github-pages@v2
1818
with:
1919
target_branch: gh-pages

.github/workflows/ci-pr-opened.yml

-4
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ jobs:
4242
name: storybooks
4343
path: |
4444
fuselage/storybook-static
45-
uikit-playground/build
46-
fuselage-ui-kit/storybook-static
4745
onboarding-ui/storybook-static
4846
layout/storybook-static
4947
publish-to-gh-pages:
@@ -65,8 +63,6 @@ jobs:
6563
- run: |
6664
rm -rf "fuselage/${{ needs.download-artifact.outputs.pr-number }}" "layout/${{ needs.download-artifact.outputs.pr-number }}" "uikit-playground/${{ needs.download-artifact.outputs.pr-number }}" "fuselage-ui-kit/${{ needs.download-artifact.outputs.pr-number }}" "onboarding-ui/${{ needs.download-artifact.outputs.pr-number }}"
6765
mv -v packages/fuselage/storybook-static "fuselage/${{ needs.download-artifact.outputs.pr-number }}"
68-
mv -v packages/uikit-playground/build "uikit-playground/${{ needs.download-artifact.outputs.pr-number }}"
69-
mv -v packages/fuselage-ui-kit/storybook-static "fuselage-ui-kit/${{ needs.download-artifact.outputs.pr-number }}"
7066
mv -v packages/onboarding-ui/storybook-static "onboarding-ui/${{ needs.download-artifact.outputs.pr-number }}"
7167
mv -v packages/layout/storybook-static "layout/${{ needs.download-artifact.outputs.pr-number }}"
7268
rm -rf packages

.github/workflows/ci-pr.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
steps:
1818
- uses: actions/setup-node@v2
1919
with:
20-
node-version: "14.17.6"
20+
node-version: "14.21.3"
2121
- uses: actions/checkout@v2
2222
- uses: actions/cache@v2
2323
id: yarn-cache
@@ -42,7 +42,5 @@ jobs:
4242
name: "storybooks-${{ github.event.number }}"
4343
path: |
4444
packages/fuselage/storybook-static
45-
packages/uikit-playground/build
46-
packages/fuselage-ui-kit/storybook-static
4745
packages/onboarding-ui/storybook-static
4846
packages/layout/storybook-static

.vscode/settings.json

+12-3
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,21 @@
1010
}
1111
],
1212
"eslint.onIgnoredFiles": "warn",
13-
"editor.codeActionsOnSave": {
14-
"source.fixAll.eslint": true
15-
},
1613
"eslint.options": {
1714
"extensions": [".js", ".jsx", ".md", ".mdx", ".ts", ".tsx", ".pegjs"]
1815
},
16+
"eslint.validate": [
17+
"javascript",
18+
"javascriptreact",
19+
"typescript",
20+
"typescriptreact",
21+
"markdown",
22+
"mdx",
23+
"pegjs"
24+
],
25+
"editor.codeActionsOnSave": {
26+
"source.fixAll.eslint": true
27+
},
1928
"editor.formatOnSave": true,
2029
"[typescript]": {
2130
"editor.formatOnSave": false
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,130 @@
1+
diff --git a/dist/generateDocgenCodeBlock.js b/dist/generateDocgenCodeBlock.js
2+
index 0993ac13e4b2aae6d24cf408d6a585b4ddeb7337..1405896291288eb1322d6c42144afd3b4fbd1abf 100644
3+
--- a/dist/generateDocgenCodeBlock.js
4+
+++ b/dist/generateDocgenCodeBlock.js
5+
@@ -34,7 +34,7 @@ function insertTsIgnoreBeforeStatement(statement) {
6+
* ```
7+
*/
8+
function setDisplayName(d) {
9+
- return insertTsIgnoreBeforeStatement(typescript_1.default.createExpressionStatement(typescript_1.default.createBinary(typescript_1.default.createPropertyAccess(typescript_1.default.createIdentifier(d.displayName), typescript_1.default.createIdentifier("displayName")), typescript_1.default.SyntaxKind.EqualsToken, typescript_1.default.createLiteral(d.displayName))));
10+
+ return insertTsIgnoreBeforeStatement(typescript_1.default.factory.createExpressionStatement(typescript_1.default.factory.createBinaryExpression(typescript_1.default.factory.createPropertyAccessExpression(typescript_1.default.factory.createIdentifier(d.displayName), typescript_1.default.factory.createIdentifier("displayName")), typescript_1.default.SyntaxKind.EqualsToken, typescript_1.default.factory.createStringLiteral(d.displayName))));
11+
}
12+
/**
13+
* Set a component prop description.
14+
@@ -65,7 +65,7 @@ function createPropDefinition(propName, prop, options) {
15+
*
16+
* @param defaultValue Default prop value or null if not set.
17+
*/
18+
- const setDefaultValue = (defaultValue) => typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral("defaultValue"),
19+
+ const setDefaultValue = (defaultValue) => typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral("defaultValue"),
20+
// Use a more extensive check on defaultValue. Sometimes the parser
21+
// returns an empty object.
22+
defaultValue !== null &&
23+
@@ -75,12 +75,19 @@ function createPropDefinition(propName, prop, options) {
24+
(typeof defaultValue.value === "string" ||
25+
typeof defaultValue.value === "number" ||
26+
typeof defaultValue.value === "boolean")
27+
- ? typescript_1.default.createObjectLiteral([
28+
- typescript_1.default.createPropertyAssignment(typescript_1.default.createIdentifier("value"), typescript_1.default.createLiteral(defaultValue.value)),
29+
+ ? typescript_1.default.factory.createObjectLiteralExpression([
30+
+ typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createIdentifier("value"), typeof defaultValue.value === "string"
31+
+ ? typescript_1.default.factory.createStringLiteral(defaultValue.value)
32+
+ : // eslint-disable-next-line no-nested-ternary
33+
+ typeof defaultValue.value === "number"
34+
+ ? typescript_1.default.factory.createNumericLiteral(defaultValue.value)
35+
+ : defaultValue.value
36+
+ ? typescript_1.default.factory.createTrue()
37+
+ : typescript_1.default.factory.createFalse()),
38+
])
39+
- : typescript_1.default.createNull());
40+
+ : typescript_1.default.factory.createNull());
41+
/** Set a property with a string value */
42+
- const setStringLiteralField = (fieldName, fieldValue) => typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral(fieldName), typescript_1.default.createLiteral(fieldValue));
43+
+ const setStringLiteralField = (fieldName, fieldValue) => typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral(fieldName), typescript_1.default.factory.createStringLiteral(fieldValue));
44+
/**
45+
* ```
46+
* SimpleComponent.__docgenInfo.props.someProp.description = "Prop description.";
47+
@@ -101,7 +108,7 @@ function createPropDefinition(propName, prop, options) {
48+
* ```
49+
* @param required Whether prop is required or not.
50+
*/
51+
- const setRequired = (required) => typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral("required"), required ? typescript_1.default.createTrue() : typescript_1.default.createFalse());
52+
+ const setRequired = (required) => typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral("required"), required ? typescript_1.default.factory.createTrue() : typescript_1.default.factory.createFalse());
53+
/**
54+
* ```
55+
* SimpleComponent.__docgenInfo.props.someProp.type = {
56+
@@ -113,7 +120,7 @@ function createPropDefinition(propName, prop, options) {
57+
*/
58+
const setValue = (typeValue) => Array.isArray(typeValue) &&
59+
typeValue.every((value) => typeof value.value === "string")
60+
- ? typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral("value"), typescript_1.default.createArrayLiteral(typeValue.map((value) => typescript_1.default.createObjectLiteral([
61+
+ ? typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral("value"), typescript_1.default.factory.createArrayLiteralExpression(typeValue.map((value) => typescript_1.default.factory.createObjectLiteralExpression([
62+
setStringLiteralField("value", value.value),
63+
]))))
64+
: undefined;
65+
@@ -130,9 +137,9 @@ function createPropDefinition(propName, prop, options) {
66+
if (valueField) {
67+
objectFields.push(valueField);
68+
}
69+
- return typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral(options.typePropName), typescript_1.default.createObjectLiteral(objectFields));
70+
+ return typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral(options.typePropName), typescript_1.default.factory.createObjectLiteralExpression(objectFields));
71+
};
72+
- return typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral(propName), typescript_1.default.createObjectLiteral([
73+
+ return typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral(propName), typescript_1.default.factory.createObjectLiteralExpression([
74+
setDefaultValue(prop.defaultValue),
75+
setDescription(prop.description),
76+
setName(prop.name),
77+
@@ -158,10 +165,10 @@ function createPropDefinition(propName, prop, options) {
78+
* @param relativeFilename Relative file path of the component source file.
79+
*/
80+
function insertDocgenIntoGlobalCollection(d, docgenCollectionName, relativeFilename) {
81+
- return insertTsIgnoreBeforeStatement(typescript_1.default.createIf(typescript_1.default.createBinary(typescript_1.default.createTypeOf(typescript_1.default.createIdentifier(docgenCollectionName)), typescript_1.default.SyntaxKind.ExclamationEqualsEqualsToken, typescript_1.default.createLiteral("undefined")), insertTsIgnoreBeforeStatement(typescript_1.default.createStatement(typescript_1.default.createBinary(typescript_1.default.createElementAccess(typescript_1.default.createIdentifier(docgenCollectionName), typescript_1.default.createLiteral(`${relativeFilename}#${d.displayName}`)), typescript_1.default.SyntaxKind.EqualsToken, typescript_1.default.createObjectLiteral([
82+
- typescript_1.default.createPropertyAssignment(typescript_1.default.createIdentifier("docgenInfo"), typescript_1.default.createPropertyAccess(typescript_1.default.createIdentifier(d.displayName), typescript_1.default.createIdentifier("__docgenInfo"))),
83+
- typescript_1.default.createPropertyAssignment(typescript_1.default.createIdentifier("name"), typescript_1.default.createLiteral(d.displayName)),
84+
- typescript_1.default.createPropertyAssignment(typescript_1.default.createIdentifier("path"), typescript_1.default.createLiteral(`${relativeFilename}#${d.displayName}`)),
85+
+ return insertTsIgnoreBeforeStatement(typescript_1.default.factory.createIfStatement(typescript_1.default.factory.createBinaryExpression(typescript_1.default.factory.createTypeOfExpression(typescript_1.default.factory.createIdentifier(docgenCollectionName)), typescript_1.default.SyntaxKind.ExclamationEqualsEqualsToken, typescript_1.default.factory.createStringLiteral("undefined")), insertTsIgnoreBeforeStatement(typescript_1.default.factory.createExpressionStatement(typescript_1.default.factory.createBinaryExpression(typescript_1.default.factory.createElementAccessExpression(typescript_1.default.factory.createIdentifier(docgenCollectionName), typescript_1.default.factory.createStringLiteral(`${relativeFilename}#${d.displayName}`)), typescript_1.default.SyntaxKind.EqualsToken, typescript_1.default.factory.createObjectLiteralExpression([
86+
+ typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createIdentifier("docgenInfo"), typescript_1.default.factory.createPropertyAccessExpression(typescript_1.default.factory.createIdentifier(d.displayName), typescript_1.default.factory.createIdentifier("__docgenInfo"))),
87+
+ typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createIdentifier("name"), typescript_1.default.factory.createStringLiteral(d.displayName)),
88+
+ typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createIdentifier("path"), typescript_1.default.factory.createStringLiteral(`${relativeFilename}#${d.displayName}`)),
89+
]))))));
90+
}
91+
/**
92+
@@ -180,15 +187,15 @@ function insertDocgenIntoGlobalCollection(d, docgenCollectionName, relativeFilen
93+
* @param options Generator options.
94+
*/
95+
function setComponentDocGen(d, options) {
96+
- return insertTsIgnoreBeforeStatement(typescript_1.default.createStatement(typescript_1.default.createBinary(
97+
+ return insertTsIgnoreBeforeStatement(typescript_1.default.factory.createExpressionStatement(typescript_1.default.factory.createBinaryExpression(
98+
// SimpleComponent.__docgenInfo
99+
- typescript_1.default.createPropertyAccess(typescript_1.default.createIdentifier(d.displayName), typescript_1.default.createIdentifier("__docgenInfo")), typescript_1.default.SyntaxKind.EqualsToken, typescript_1.default.createObjectLiteral([
100+
+ typescript_1.default.factory.createPropertyAccessExpression(typescript_1.default.factory.createIdentifier(d.displayName), typescript_1.default.factory.createIdentifier("__docgenInfo")), typescript_1.default.SyntaxKind.EqualsToken, typescript_1.default.factory.createObjectLiteralExpression([
101+
// SimpleComponent.__docgenInfo.description
102+
- typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral("description"), typescript_1.default.createLiteral(d.description)),
103+
+ typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral("description"), typescript_1.default.factory.createStringLiteral(d.description)),
104+
// SimpleComponent.__docgenInfo.displayName
105+
- typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral("displayName"), typescript_1.default.createLiteral(d.displayName)),
106+
+ typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral("displayName"), typescript_1.default.factory.createStringLiteral(d.displayName)),
107+
// SimpleComponent.__docgenInfo.props
108+
- typescript_1.default.createPropertyAssignment(typescript_1.default.createLiteral("props"), typescript_1.default.createObjectLiteral(Object.entries(d.props).map(([propName, prop]) => createPropDefinition(propName, prop, options)))),
109+
+ typescript_1.default.factory.createPropertyAssignment(typescript_1.default.factory.createStringLiteral("props"), typescript_1.default.factory.createObjectLiteralExpression(Object.entries(d.props).map(([propName, prop]) => createPropDefinition(propName, prop, options)))),
110+
]))));
111+
}
112+
function generateDocgenCodeBlock(options) {
113+
@@ -196,7 +203,7 @@ function generateDocgenCodeBlock(options) {
114+
const relativeFilename = path_1.default
115+
.relative("./", path_1.default.resolve("./", options.filename))
116+
.replace(/\\/g, "/");
117+
- const wrapInTryStatement = (statements) => typescript_1.default.createTry(typescript_1.default.createBlock(statements, true), typescript_1.default.createCatchClause(typescript_1.default.createVariableDeclaration(typescript_1.default.createIdentifier("__react_docgen_typescript_loader_error")), typescript_1.default.createBlock([])), undefined);
118+
+ const wrapInTryStatement = (statements) => typescript_1.default.factory.createTryStatement(typescript_1.default.factory.createBlock(statements, true), typescript_1.default.factory.createCatchClause(typescript_1.default.factory.createVariableDeclaration(typescript_1.default.factory.createIdentifier("__react_docgen_typescript_loader_error")), typescript_1.default.factory.createBlock([])), undefined);
119+
const codeBlocks = options.componentDocs.map((d) => wrapInTryStatement([
120+
options.setDisplayName ? setDisplayName(d) : null,
121+
setComponentDocGen(d, options),
122+
@@ -208,7 +215,7 @@ function generateDocgenCodeBlock(options) {
123+
const printer = typescript_1.default.createPrinter({ newLine: typescript_1.default.NewLineKind.LineFeed });
124+
const printNode = (sourceNode) => printer.printNode(typescript_1.default.EmitHint.Unspecified, sourceNode, sourceFile);
125+
// Concat original source code with code from generated code blocks.
126+
- const result = codeBlocks.reduce((acc, node) => `${acc}\n${printNode(node)}`,
127+
+ const result = codeBlocks.reduce((acc, node) => `${acc}\n${printNode(node)}`,
128+
// Use original source text rather than using printNode on the parsed form
129+
// to prevent issue where literals are stripped within components.
130+
// Ref: https://github.com/strothj/react-docgen-typescript-loader/issues/7

0 commit comments

Comments
 (0)