DynamicField MasterSlave missing in AgentTicketMasterSlave and AgentTicketBulk

[svenoe]

From RotherOSS/otobo#1334

After installing the Feature MasterSlave, a new action is added: AgentTicketMasterSlave But: here the new dynamic field MasterSlave is missing. In my opinion it should be there by default - as the new action usually has no other purpose.

Also in my opinion it also should be there in AgentTicketBulk

Tested with OTOBO 10.0.13 (ov48) with MasterSlave 10.0.1

[svenoe]

@reneeb answered:

IMHO this should be reported at https://github.com/RotherOSS/MasterSlave as this should be handled in the packagesetup script there.

Relevant are the lines after

MasterSlave/var/packagesetup/MasterSlave.pm

Line 340 in 7a866ef

# enable dynamic field for ticket zoom

For the addition in AgentTicketBulk we would first have to enable dynamic fields there in general. (We have a package for that, but only with reduced functionality (no ACLs e.g., as they are not always well defined for a bundle of tickets).)

Also isn't the other thing just a SysConfig option? I would assume Stefan is not talking about AgentTicketZoom, but rather AgentTicketMasterSlave or so, where it is just not part of ###DynamicFields, I guess.

[svenoe]

Edit: I read too fast, its called "AdvancedEnabled" - someone probably has to go through it somewhen, or rather Stefan, what do you actually change to get the field in?

Old:

Hm...this module is built a bit different than usual. The name of the MasterSlave dynamic field is configurable, thus the usual option does not exists. As far as I understand it, the field is only shown when the MasterSlave functionality is enabled (which makes sense - though without it being enabled, the Module doesn't make much sense),

MasterSlave/Kernel/Modules/AgentTicketMasterSlave.pm

Lines 371 to 372 in 7a866ef

	my $MasterSlaveDynamicField = $ConfigObject->Get('MasterSlave::DynamicField') || '';
	my $MasterSlaveAdvancedEnabled = $ConfigObject->Get('MasterSlave::AdvancedEnabled') || 0;

and the package comes with its functionality being disabled. I only had a quick look, but for me the question rather is whether we should change the default state of the functionality to being enabled. This again would in principle be fine I guess (why else would you install it), but then the configurable field name might be problematic...

[stefanhaerter]

@StefanAbel-OTOBO @svenoe Code-side I would consider it a relatively small change to enable the dynamic field per default for AgentTicketMasterSlave. Has there a decision been made yet if this is wanted?