Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'IS NULL' and default value are not added when extra source columns are migrated #1908

Open
bschmalhofer opened this issue Sep 2, 2022 · 1 comment · May be fixed by #2062
Open

'IS NULL' and default value are not added when extra source columns are migrated #1908

bschmalhofer opened this issue Sep 2, 2022 · 1 comment · May be fixed by #2062
Assignees
@bschmalhofer
Labels
bug Something isn't working as intended migration primarily migration from OTRS to OTOBO

Comments

@bschmalhofer
Copy link
Contributor

migration.pl supports the feature that extra columns from the source database are also migrated to the target database. These extra columns should have the same name and the same data type as the source columns. But it looks like this does not work for 'IS NULL'. The reason is that in e.g. in https://github.com/RotherOSS/otobo/blob/rel-10_1/Kernel/System/MigrateFromOTRS/CloneDB/Driver/mysql.pm#L296 the check is $ColumnInfos{IS_NULLABLE} =~ /no/ while IS_NULLABLE is either NO or YES.
@bschmalhofer bschmalhofer added bug Something isn't working as intended migration primarily migration from OTRS to OTOBO labels Sep 2, 2022
@bschmalhofer bschmalhofer self-assigned this Sep 2, 2022
@bschmalhofer
Copy link
Contributor Author

Maybe also add the default value from the source database.

@bschmalhofer bschmalhofer changed the title 'IS NULL' is not added when extra source columns are migrated 'IS NULL' and default value are not added when extra source columns are migrated Dec 22, 2022
dennis-dko pushed a commit that referenced this issue Dec 22, 2022
Issue #1908: Updating sql drivers (mysql, oracle, postgres) to use de…
532fa24 
…fault value and not null column attributes correctly.
dennis-dko pushed a commit that referenced this issue Dec 22, 2022
Issue #1908: Updating sql drivers to use bind by execute.
9df8b6c
dennis-dko pushed a commit that referenced this issue Dec 22, 2022
Issue #1908: Updating sql drivers to use NOT NULL and DEFAULT correct…
eac8faa 
…ly, cannot use bind because it will quote variables with inverted commas in sql query.
@dennis-dko dennis-dko linked a pull request Dec 22, 2022 that will close this issue
Issue #1908 is null is not added when extra source columns are migrated #2062
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
bug Something isn't working as intended migration primarily migration from OTRS to OTOBO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1908 is null is not added when extra source columns are migrated RotherOSS/otobo
2 participants
@bschmalhofer @dennis-dko