-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client::new() panics when JACK is not installed #176
Comments
This is a regression from #172, which IMO should be reverted. |
robbert-vdh
added a commit
to robbert-vdh/rust-jack
that referenced
this issue
Jul 13, 2022
Before this trying to initialize a client when JACK was not avaiable would result in an unrecoverable panic because of an unwrap on `jack_sys::library()`. Fixes RustAudio#176
robbert-vdh
added a commit
to robbert-vdh/rust-jack
that referenced
this issue
Jul 13, 2022
Before this trying to initialize a client when JACK was not avaiable would result in an unrecoverable panic because of an unwrap on `jack_sys::library()`. Fixes RustAudio#176
robbert-vdh
added a commit
to robbert-vdh/rust-jack
that referenced
this issue
Jul 13, 2022
Before this trying to initialize a client when JACK was not available would result in an unrecoverable panic because of an unwrap on `jack_sys::library()`. Fixes RustAudio#176
I think you can fix this by using version 0.9.2. |
robbert-vdh
added a commit
to robbert-vdh/rust-jack
that referenced
this issue
Jul 13, 2022
Before this trying to initialize a client when JACK was not available would result in an unrecoverable panic because of an unwrap on `jack_sys::library()`. Fixes RustAudio#176
I fixed this with #177. |
robbert-vdh
added a commit
to robbert-vdh/rust-jack
that referenced
this issue
Oct 31, 2022
Before this trying to initialize a client when JACK was not available would result in an unrecoverable panic because of an unwrap on `jack_sys::library()`. Fixes RustAudio#176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd expect this to return an error if JACK is not available, but right now it just panics on an unwrap.
When creating a client, the library immediately calls
jack_set_error_function
:rust-jack/src/client/client_impl.rs
Lines 49 to 54 in 6133ac4
And those functions call
jack_sys::library().unwrap()
:rust-jack/jack-sys/build.rs
Line 54 in 6133ac4
So if the library is not available or cannot be loaded, creating a client will panic instead of returning an error.
The text was updated successfully, but these errors were encountered: