Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing names for AES-SIV algorithms #479

Open
davidv1992 opened this issue Sep 28, 2022 · 1 comment
Open

Confusing names for AES-SIV algorithms #479

davidv1992 opened this issue Sep 28, 2022 · 1 comment

Comments

@davidv1992
Copy link

The current naming scheme in the AES-SIV uses a different naming scheme for the lengths than rfc5297, naming the algorithm lengths to the number of bits of security provided rather than the key length. This is highly confusing for potential users refering to standards documents and or the IANA registry of AEAD algorithm identifiers.

From my perspective, ideally these aeads should follow the naming convention from the rfc, but if not this should be clearly indicated in the documentation so as to avoid pitfalls for new users.

@tarcieri
Copy link
Member

tarcieri commented Sep 28, 2022

I assume you're referring to the names in RFC5297 Section 6, i.e. AEAD_AES_SIV_CMAC_256, AEAD_AES_SIV_CMAC_384, AEAD_AES_SIV_CMAC_512.

FWIW I have never seen any other cryptographic library use those names:

...just as a few examples.

Trying to adopt the key-size-not-security-level names would also make the naming inconsistent with the aes-gcm-siv crate. And in general, I think it would make things more confusing for users.

We can add a comment to the type declaration for each of the AEADs which provides the RFC5297 name, however I don't think it makes sense to change the actual type names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@tarcieri @davidv1992 and others