ssh-key: use elliptic curve crate releases (#420)

Switches from `git`-sourced dependencies to crate releases for:
- `ed25519-dalek`
- `p256`
- `p384`
- `p521`

Author: tarcieri

Cargo.lock

@@ -16,12 +16,3 @@ ssh-cipher = { path = "./ssh-cipher" }
 ssh-derive = { path = "./ssh-derive" }
 ssh-encoding = { path = "./ssh-encoding" }
 ssh-key = { path = "./ssh-key" }
-
-ed25519-dalek = { git = "https://github.com/dalek-cryptography/curve25519-dalek", branch = "rand_core/v0.10-rc" }
-elliptic-curve = { git = "https://github.com/RustCrypto/traits" }
-ff = { git = "https://github.com/tarcieri/ff", branch = "rand_core/v0.10.0-rc-2" }
-group = { git = "https://github.com/tarcieri/group", branch = "rand_core/v0.10.0-rc-2" }
-p256 = { git = "https://github.com/RustCrypto/elliptic-curves" }
-p384 = { git = "https://github.com/RustCrypto/elliptic-curves" }
-p521 = { git = "https://github.com/RustCrypto/elliptic-curves" }
-primefield = { git = "https://github.com/RustCrypto/elliptic-curves " }

Cargo.toml

@@ -29,12 +29,12 @@ zeroize = { version = "1", default-features = false }
 argon2 = { version = "0.6.0-rc.2", optional = true, default-features = false, features = ["alloc"] }
 bcrypt-pbkdf = { version = "0.11.0-rc.2", optional = true, default-features = false, features = ["alloc"] }
 dsa = { version = "0.7.0-rc.7", optional = true, default-features = false, features = ["hazmat"] }
-ed25519-dalek = { version = "=3.0.0-pre.1", optional = true, default-features = false }
+ed25519-dalek = { version = "=3.0.0-pre.2", optional = true, default-features = false }
 hex = { version = "0.4", optional = true, default-features = false, features = ["alloc"] }
 hmac = { version = "0.13.0-rc.3", optional = true }
-p256 = { version = "0.14.0-rc.0", optional = true, default-features = false, features = ["ecdsa"] }
-p384 = { version = "0.14.0-rc.0", optional = true, default-features = false, features = ["ecdsa"] }
-p521 = { version = "0.14.0-rc.0", optional = true, default-features = false, features = ["ecdsa"] }
+p256 = { version = "0.14.0-rc.1", optional = true, default-features = false, features = ["ecdsa"] }
+p384 = { version = "0.14.0-rc.1", optional = true, default-features = false, features = ["ecdsa"] }
+p521 = { version = "0.14.0-rc.1", optional = true, default-features = false, features = ["ecdsa"] }
 rand_core = { version = "0.10.0-rc-2", optional = true, default-features = false }
 rsa = { version = "0.10.0-rc.10", optional = true, default-features = false, features = ["sha2"] }
 sec1 = { version = "0.8.0-rc.10", optional = true, default-features = false, features = ["point"] }

ssh-key/Cargo.toml

@@ -211,7 +211,7 @@ impl EcdsaKeypair {
         match curve {
             #[cfg(feature = "p256")]
             EcdsaCurve::NistP256 => {
-                let private = p256::SecretKey::random(rng);
+                let Ok(private) = p256::SecretKey::try_from_rng(rng);
                 let public = private.public_key();
                 Ok(EcdsaKeypair::NistP256 {
                     private: private.into(),
@@ -220,7 +220,7 @@ impl EcdsaKeypair {
             }
             #[cfg(feature = "p384")]
             EcdsaCurve::NistP384 => {
-                let private = p384::SecretKey::random(rng);
+                let Ok(private) = p384::SecretKey::try_from_rng(rng);
                 let public = private.public_key();
                 Ok(EcdsaKeypair::NistP384 {
                     private: private.into(),
@@ -229,7 +229,7 @@ impl EcdsaKeypair {
             }
             #[cfg(feature = "p521")]
             EcdsaCurve::NistP521 => {
-                let private = p521::SecretKey::random(rng);
+                let Ok(private) = p521::SecretKey::try_from_rng(rng);
                 let public = private.public_key();
                 Ok(EcdsaKeypair::NistP521 {
                     private: private.into(),