Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign as child API #398

Open
DanielleHuisman opened this issue Dec 31, 2024 · 2 comments · Fixed by #417
Open

Redesign as child API #398

DanielleHuisman opened this issue Dec 31, 2024 · 2 comments · Fixed by #417
Assignees
@DanielleHuisman
Labels
type: feature Feature

Comments

@DanielleHuisman
Copy link
Member

DanielleHuisman commented Dec 31, 2024 •
edited
Loading

The React Radix asChild API is hard to remake in Rust and the current solution is not great. The goal of this issue is to design an API to approximate the React as child API.
@DanielleHuisman DanielleHuisman self-assigned this Dec 31, 2024
@DanielleHuisman DanielleHuisman mentioned this issue Jan 3, 2025
Merged
@geoffreygarrett
Copy link
Contributor

I have a fully functional and tested solution, I'm hoping for your reviews on the upstream PRs I'm making.

@geoffreygarrett
Copy link
Contributor

Removing Primitive breaks shadcn/ui. I have PRs with fixes and am happy to adjust naming conventions or other details to help. Can we discuss how to move forward and ensure compatibility? RustForWeb/leptos-utils#16

@geoffreygarrett geoffreygarrett mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielleHuisman DanielleHuisman

Labels
type: feature Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Primitive to Leptos 0.7 geoffreygarrett/radix
2 participants
@DanielleHuisman @geoffreygarrett