Open
Description
Currently
The current implementation of Action
doesn't allow you to receive the Swift.Error
when .execution
is called. But we get an ActionError
type which is not really useful because you always have to switch within it to the underlyingError
.
Proposal
I think it would be nice for the framework to have something like var underlyingErrors: Observable<Swift.Error>
which will only emit when .execution
actually has an error
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Activity
ashfurrow commentedon Oct 27, 2017
That makes sense to me, I believe ReactiveSwift's
Command
type has something similar. Let's do it!dangthaison91 commentedon Jan 8, 2018
Should
.errors
will beObservable<Swift.Error>
while.executionErrors
/actionErrors
will beObservable<ActionError>
? @bobgodwinxbobgodwinx commentedon Jan 8, 2018
@dangthaison91 exactly, the idea is to separate the errors related to the
output
from theexecutionErrors
this will make sure that on.errors
we will be getting onlySwift.Error
. Do plan on submitting a PR?