Skip to content

"&" characters in organization name result in an error when trying to build metadata #576

Open
@0xmerp

Description

@0xmerp

In advanced settings, when setting the organization name to something including a & character:

    'organization' => array (
        'en-US' => array(
            'name' => 'Name & Name2',
            'displayname' => 'Name & Name2',
            'url' => 'https://some-url.com'
        ),
    ),

then fetching the SP metadata:

    $samlSettings = new Settings($saml_settings);
    $metadata = $samlSettings->getSPMetadata();

I get an error: Error parsing metadata. Error parsing metadata from Saml2/Metadata.php:

        try {
			
            $xml = Utils::loadXML($xml, $metadata);
			
            if (!$xml) {
                throw new Exception('Error parsing metadata');
            }
        } catch (Exception $e) {
            throw new Exception('Error parsing metadata. '.$e->getMessage());
        }

Changing the & character with & fixes it, so it seems like this string wasn't being escaped properly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions