Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Tenant Tutorial: add redirect-uris in xs-security.json to fix 'Call the Service via Approuter' #846

Open
JenniferStamm opened this issue Aug 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@JenniferStamm
Copy link

Describe the bug
login callback uri wasn't built correctly.

To Reproduce
Follow the tutorial up to step 'Call the Service via Approuter'. The call will fail and you'll find the misconfigured callback url in the browser's dev tool console.

Expected behavior
No authentication/authorization issues.

Used Versions:

  • node version via node -v: v18.15.0
  • npm version via npm -v: 9.5.0
  • SAP Cloud SDK version you used as dependency: does not apply, because the issue was with @sap/approuter and XSUAA
  • @sap/approuter": "14.3.0"

Code Examples
Updating XSUAA xs-security.json with redirect-uri property fixed the issue.

Additional context
Following the contributing guidelines, I'd rather discuss the change before submitting a PR. It was an educated guess based on previous experience with XSUAA's xs-security.json. I don't know why we needed that property to get it working and whether it can be safely added for everyone.

@JenniferStamm JenniferStamm added the bug Something isn't working label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant