Skip to content

Conversation

@xiaoyu0722
Copy link
Contributor

Toolbar layout updated for iOS 26, needs more padding and also bug fix for toolbar with helper text

Ref: #1267

Toolbar layout updated for iOS 26, needs more padding and also bug fix
for toolbar with helper text
@xiaoyu0722 xiaoyu0722 requested a review from a team as a code owner September 19, 2025 02:25
@xiaoyu0722 xiaoyu0722 requested review from billzhou0223 and removed request for a team September 19, 2025 02:25
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix build/test failure

Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For rel-25.8, it does not use Xcode 26. So, the new API will not be available.
So, ToolbarSpacer will not work to build here, since rel-25.8 uses Xcode 16.4.

@xiaoyu0722 xiaoyu0722 added the Do not merge yet Do not merge yet label Sep 23, 2025
@dyongxu
Copy link
Contributor

dyongxu commented Oct 21, 2025

@xiaoyu0722 Since we have no plan to use Xcdoe 26 for rel-25.8, I closed this PR.

@dyongxu dyongxu closed this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do not merge yet Do not merge yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants