feat: 🎸 HCPSDKFIORIUIKIT-3001, Loading Indicator on Upload #1295
Conversation
Adding loading and error state to attachment grid/list; allowing extra info for custom style BREAKING CHANGE: 🧨 data model ✅ Closes: 1
CharlesXu0488
requested review from
billzhou0223 and
dyongxu
and removed request for
a team
CharlesXu0488
force-pushed
the
HCPSDKFIORIUIKIT-3001
branch
from
480fcac to
fbac5a6
Compare
CharlesXu0488
force-pushed
the
HCPSDKFIORIUIKIT-3001
branch
from
3b9d59a to
19bf79d
Compare
|
Docs and Tests were added. |
Apps/Examples/Examples/FioriSwiftUICore/Attachment/AttachmentDelegateExample.swift
Outdated
Show resolved
Hide resolved
Sources/FioriSwiftUICore/_ComponentProtocols/CompositeComponentProtocols.swift
Outdated
Show resolved
Hide resolved
...riSwiftUICore/_generated/StyleableComponents/AttachmentGroup/AttachmentGroup.generated.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Correct some typos:
./_generated/StyleableComponents/Attachment/Attachment.generated.swift:37: attachement ==> attachment
./_generated/StyleableComponents/AttachmentButtonImage/AttachmentButtonImage.generated.swift:17: Attachements ==> Attachments
./_generated/StyleableComponents/AttachmentButtonImage/AttachmentButtonImage.generated.swift:32: poping ==> popping, pooping
./_generated/StyleableComponents/AttachmentButtonImage/AttachmentButtonImage.generated.swift:34: attachement ==> attachment
./_generated/StyleableComponents/AttachmentThumbnail/AttachmentThumbnail.generated.swift:24: attachement ==> attachment
./_generated/StyleableComponents/AttachmentGroup/AttachmentGroup.generated.swift:11: Attachements ==> Attachments
./_generated/StyleableComponents/AttachmentGroup/AttachmentGroup.generated.swift:30: maximium ==> maximum
./_generated/StyleableComponents/AttachmentGroup/AttachmentGroup.generated.swift:32: attachemnt ==> attachment
./_generated/StyleableComponents/AttachmentGroup/AttachmentGroup.generated.swift:34: attachement ==> attachment
more typos found addressed |
2 participants
JIRA HCPSDKFIORIUIKIT-3001 requires for loading indicators for in-progress uploading attachments. To address that, 3 states, uploading, uploaded, and error, were introduced.
With this PR, in-grid/in-list loadings and errors are shown together with uploaded attachments. Additionally, extra info is allowed to be associated with each uploaded attachment. Apps need to provide default extra info value and use the extra info in custom style if the apps need the extra info.
BREAKING CHANGE: 🧨 data model
✅ Closes: 1
Uploading and Error
https://github.com/user-attachments/assets/3c615043-abcd-4ea8-8b0b-eaea6e93112a
Extra Info
https://github.com/user-attachments/assets/c3aba460-2020-41a9-a61f-0f24e9b8750a
Batch (change states outside of AttachmentGroup)
https://github.com/user-attachments/assets/267ea219-2d9e-4b04-938c-a5bac663e55e