Skip to content

Commit 778c68c

Browse files
fix(core): update the CSS for Slider Tooltip (#12377)
1 parent f7cc4ee commit 778c68c

File tree

4 files changed

+31
-33
lines changed

4 files changed

+31
-33
lines changed

libs/core/slider/slider.component.html

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
[appendTo]="handle"
111111
[disabled]="!tooltipMode"
112112
class="fd-popover--slider"
113-
additionalBodyClass="fd-slider--tooltip-popover"
113+
additionalBodyClass="fd-slider-tooltip-popover"
114114
placement="top"
115115
>
116116
<ng-template
@@ -192,7 +192,7 @@
192192
[closeOnOutsideClick]="false"
193193
[appendTo]="rangeHandle1"
194194
[disabled]="!tooltipMode"
195-
additionalBodyClass="fd-slider--tooltip-popover"
195+
additionalBodyClass="fd-slider-tooltip-popover"
196196
class="fd-popover--slider"
197197
placement="top"
198198
>
@@ -207,7 +207,7 @@
207207
[closeOnOutsideClick]="false"
208208
[appendTo]="rangeHandle2"
209209
[disabled]="!tooltipMode"
210-
additionalBodyClass="fd-slider--tooltip-popover"
210+
additionalBodyClass="fd-slider-tooltip-popover"
211211
class="fd-popover--slider"
212212
placement="top"
213213
>
@@ -220,14 +220,14 @@
220220
<ng-template #popoverInner let-target="target" let-position="position">
221221
<div
222222
#sliderTooltipWrapper
223-
class="fd-slider--tooltip-wrapper"
223+
class="fd-slider-tooltip-wrapper"
224224
(click)="$event.stopPropagation()"
225225
(keydown)="$event.stopPropagation()"
226226
(mouseenter)="_popoverInputFieldHovered$.next(true)"
227227
(mouseleave)="_popoverInputFieldHovered$.next(false)"
228228
>
229229
@if ((customValues && customValues.length > 0) || tooltipMode === 'readonly') {
230-
<div class="fd-slider--tooltip">
230+
<div class="fd-slider-tooltip">
231231
{{ customValues && customValues.length > 0 ? customValues[position].label : _popoverValueRef[target] }}
232232
</div>
233233
}
@@ -240,7 +240,7 @@
240240
fdkOnlyDigits
241241
[decimal]="true"
242242
[style.width.ch]="('' + _popoverValueRef[target]).length + 2"
243-
class="fd-input fd-slider--tooltip {{ _popoverInputFieldClass }}"
243+
class="fd-input fd-slider-tooltip {{ _popoverInputFieldClass }}"
244244
[(ngModel)]="_popoverValueRef[target]"
245245
(blur)="_updateValueFromInput(popoverInputField.value, target)"
246246
(keydown.enter)="_updateValueFromInput(popoverInputField.value, target)"

libs/core/slider/slider.component.scss

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,30 @@
88
display: block !important;
99
}
1010

11-
.fd-popover__body.fd-slider--tooltip-popover {
12-
top: -7px !important;
11+
.fd-popover__body.fd-slider-tooltip-popover {
12+
height: 1rem;
13+
border: none;
14+
padding-block: 0;
1315
overflow: hidden;
16+
padding-inline: 0.5rem;
17+
border-radius: 0.0625rem;
18+
top: -0.4375rem !important;
19+
background: var(--sapBackgroundColor);
20+
box-shadow: var(--sapContent_Shadow1);
1421

15-
.fd-slider--tooltip {
16-
padding: 0.25rem;
17-
min-width: 2rem;
22+
.fd-slider-tooltip {
23+
line-height: 1rem;
1824
text-align: center;
19-
height: 1.375rem;
20-
line-height: 1;
21-
direction: ltr;
22-
box-sizing: border-box;
23-
24-
margin: 0 !important;
25-
border: 0;
25+
color: var(--sapTextColor);
26+
font-family: var(--sapFontFamily);
27+
font-size: var(--sapFontSmallSize);
28+
}
2629

27-
color: #6a6d70;
28-
color: var(--sapContent_LabelColor, #6a6d70);
29-
font-size: 0.875rem;
30-
font-size: var(--sapFontSize);
30+
&:has(input) {
31+
width: auto;
32+
height: auto;
33+
box-shadow: none;
34+
padding-inline: 0;
3135
}
3236
}
3337

@@ -38,6 +42,7 @@
3842
padding-bottom: 2rem;
3943
}
4044

45+
// Has to stay in ngx
4146
&__tick-wrapper {
4247
.fd-slider__label,
4348
.fd-slider__tick {
@@ -70,13 +75,6 @@
7075
white-space: nowrap;
7176
}
7277
}
73-
74-
// IE11 workaround
75-
&__alternative-tick-width {
76-
.fd-slider__tick {
77-
width: 1px;
78-
}
79-
}
8078
}
8179

8280
[dir='rtl'] {

libs/docs/core/slider/e2e/slider.po.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ export class SliderPo extends CoreBaseComponentPo {
1818
// main selectors
1919
sliderHandles = '.fd-slider__handle';
2020
valueLabels = 'p:nth-of-type(2)';
21-
sliderTooltip = 'fd-popover-body .fd-slider--tooltip';
21+
sliderTooltip = 'fd-popover-body .fd-slider-tooltip';
2222
sliderTooltipInput = 'fd-popover-body .fd-popover__body input';
23-
sliderTooltipInputFF = 'fd-popover-body .fd-slider--tooltip-wrapper input';
23+
sliderTooltipInputFF = 'fd-popover-body .fd-slider-tooltip-wrapper input';
2424
sliderAttr = 'fd-slider';
2525
sliderLabels = '.fd-slider__labels';
2626
sliderLabel = '.fd-slider__label';

libs/docs/platform/slider/e2e/slider.po.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@ export class SliderPo extends PlatformBaseComponentPo {
1818
sliderHandles = '.fd-slider__handle';
1919
valueLabels = 'p:nth-of-type(2)';
2020
formValueLabels = 'p';
21-
sliderTooltip = 'fd-popover-body .fd-slider--tooltip';
21+
sliderTooltip = 'fd-popover-body .fd-slider-tooltip';
2222
sliderTooltipInput = 'fd-popover-body .fd-popover__body input';
23-
sliderTooltipInputFF = 'fd-popover-body .fd-slider--tooltip-wrapper input';
23+
sliderTooltipInputFF = 'fd-popover-body .fd-slider-tooltip-wrapper input';
2424
sliderAttr = 'fd-slider';
2525
altSliderAttr = 'fdp-slider';
2626
sliderLabels = '.fd-slider__labels';

0 commit comments

Comments
 (0)