You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Trying to resolve a missing type reported here: SAP/openui5#4178 I noticed it was reported to be fixed in the coding (JSdoc), but the type definitions in both @sapui5/types and @types/openui5 do not seem to reflect the changes.
@sapui5/types/sap.m.d.ts:23511:
/**
* Escape handler for sap.m.Dialog control.
*/
export type EscapeHandler = (oHandlers: object) => void;
Where object should have been replaced with a different structure
The text was updated successfully, but these errors were encountered:
@willempardaens Hm, in the type definitions diff of 1.134, you can see that the relevant parts of sap.m have changed. Line 23491 of the sap.m types has the EscapeHandler type (which you, by the way, also quote above), and line 23189 (and others) use this type, so in general, the fix has arrived in the types.
But I see, your point is that the structure
{
resolve: Function;
reject: Function;
}
has been simplified to object, although the fix has apparently tried to define the actual structure.
The api.json intermediate file also does contain this structure, so it seems indeed like this hits a spot where the dts-generator does not yet support all possible kinds of input.
Trying to resolve a missing type reported here: SAP/openui5#4178 I noticed it was reported to be fixed in the coding (JSdoc), but the type definitions in both
@sapui5/types
and@types/openui5
do not seem to reflect the changes.@sapui5/types/sap.m.d.ts:23511
:Where
object
should have been replaced with a different structureThe text was updated successfully, but these errors were encountered: