refactor(ui5-toolbar): items made physical #11374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 79216a5.
…ents into toolbar-items-physical
dobrinyonkov
requested changes
May 12, 2025
Contributor
There was a problem hiding this comment.
A few class members that are no longer used can be deleted:
Toolbar
getRegisteredToolbarItemByID- and
itemsDOM
- and
getItemByIDhasItemWithText- and ToolbarItem's
containsText
- and ToolbarItem's
itemsWidthMeasured
ToolbarItem
containsTexttoolbarTemplatetoolbarPopoverTemplate
PR's title needs to include the refactor semantic tag.
Also, we can describe a short summary of the changes in the PR's body.
dobrinyonkov
requested changes
May 27, 2025
Contributor
|
PR's title needs to include the refactor semantic tag. |
PetyaMarkovaBogdanova
changed the title
dobrinyonkov
approved these changes
May 27, 2025
Closed
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Requests represents ui5-toolbar items, which were until now rendered as an abstract items, as physical.
Since Popover Static area is not presented anymore we now render the slotted toolbar items directly with jsxRenderer and semantic ui5-toolbar-*(item name) are now part of the shadow DOM of the ui5-toolbar.
Items now contain isOverflowed property, which can distinguish if the item is in the Toolbar or in the Overflow Popover.
Fixes: #10622