Skip to content

Commit fbfd186

Browse files
committed
Update the github-ci with visionOS
1 parent 24c18bf commit fbfd186

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/CI.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ jobs:
171171
iOSSCHEME: SDWebImageSwiftUI
172172
TVSCHEME: SDWebImageSwiftUI tvOS
173173
WATCHSCHEME: SDWebImageSwiftUI watchOS
174+
VISIONOSSCHEME: SDWebImageSwiftUI visionOS
174175
steps:
175176
- name: Checkout
176177
uses: actions/checkout@v3
@@ -185,7 +186,7 @@ jobs:
185186
run: brew install carthage
186187

187188
- name: Carthage Update
188-
run: ./carthage.sh update --platform "iOS, tvOS, macOS, watchOS"
189+
run: ./carthage.sh update --platform "iOS, tvOS, macOS, watchOS, visionOS"
189190

190191
- name: Build as dynamic frameworks
191192
run: |
@@ -194,3 +195,4 @@ jobs:
194195
xcodebuild build -project "${{ env.PROJECT_NAME }}" -scheme "${{ env.iOSSCHEME }}" -sdk iphoneos -configuration Release | xcpretty -c
195196
xcodebuild build -project "${{ env.PROJECT_NAME }}" -scheme "${{ env.TVSCHEME }}" -sdk appletvos -configuration Release | xcpretty -c
196197
xcodebuild build -project "${{ env.PROJECT_NAME }}" -scheme "${{ env.WATCHSCHEME }}" -sdk watchos -configuration Release | xcpretty -c
198+
xcodebuild build -project "${{ env.PROJECT_NAME }}" -scheme "${{ env.VISIONOSSCHEME }}" -sdk xros -configuration Release | xcpretty -c

Tests/ImageManagerTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class ImageManagerTests: XCTestCase {
1717

1818
func testImageManager() throws {
1919
let expectation = self.expectation(description: "ImageManager usage with Combine")
20-
let imageUrl = URL(string: "https://via.placeholder.com/500x500.jpg")
20+
let imageUrl = URL(string: "https://placehold.co/500x500.jpg")
2121
let imageManager = ImageManager()
2222
imageManager.setOnSuccess { image, cacheType, data in
2323
XCTAssertNotNil(image)

Tests/WebImageTests.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ class WebImageTests: XCTestCase {
137137

138138
func testWebImageOnSuccessWhenCacheMiss() throws {
139139
let expectation = self.expectation(description: "WebImage onSuccess when cache miss")
140-
let imageUrl = URL(string: "http://via.placeholder.com/100x100.png")
140+
let imageUrl = URL(string: "https://placehold.co/100x100.png")
141141
let cacheKey = SDWebImageManager.shared.cacheKey(for: imageUrl)
142142
SDImageCache.shared.removeImageFromMemory(forKey: cacheKey)
143143
SDImageCache.shared.removeImageFromDisk(forKey: cacheKey)

0 commit comments

Comments
 (0)