Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project (fork) still alive? #457

Open
barni2000 opened this issue Apr 27, 2020 · 4 comments
Open

Is this project (fork) still alive? #457

barni2000 opened this issue Apr 27, 2020 · 4 comments

Comments

@barni2000
Copy link

barni2000 commented Apr 27, 2020

I would be interested to know if the project is still alive. I have not seen any activity since February.
And all pull requests is stuck.

What will be the future of the project?

PS.: I'm just worried.

@barni2000 barni2000 changed the title Is this fork still alive? Is this project (fork) still alive? Apr 27, 2020
@wdoekes
Copy link
Member

wdoekes commented Apr 29, 2020

Hi @barni2000,

this project is not dead. But the people with commit powers have little time to work on it.

There are indeed a few open PRs, but not all of them are "ready to merge". Getting features included is a matter of getting the following checkboxes right:

  • Without this changeset, SIPp is worse than the previous version.
  • The changeset follows coding standards, is self documenting and has a good commit message (the "why").
  • The code does not simply add yet another feature, but consolidates the existing features to make the codebase maintainable in the long run.
  • Documentation about changes and backwards compatibilities is available both in the CLI help and the RST.
  • It tries to make upgrading to the next SIPp version not too much of a hassle.
  • The change does not raise expectations of what SIPp can do without living up to its promise.
  • One of the committers is affected by this change or knows someone who is. Or the PR is accompanied by a compelling argument.

Getting more checkboxes ticked means someone is more likely to invest time in code review and merging. Not all of those criteria are objective, I know. But you have to remember that no one is getting paid directly to work on this (although they might get paid by their employer or customer).

To many of us, SIPp is a necessary evil. We use it because we haven't found a suitable alternative and we have invested time into getting it into our (or our customers') test procedures. There are some fundamental flaws, the code is supposedly C++ but it uses verbose and error-prone C much of the time, there is feature bloat where new things have been added in an inconsistent manner. But when it works, it works.

So yes: keep sending us your bug fixes and feature improvements. But try to get most of the checkboxes checked.

Cheers,
Walter

@wdoekes wdoekes pinned this issue Apr 29, 2020
@orgads orgads closed this as completed Apr 1, 2024
@orgads orgads unpinned this issue Apr 1, 2024
@wdoekes
Copy link
Member

wdoekes commented Apr 1, 2024

@orgads: Was closing this warranted?

Unless you're going to be really active, I think most of what's in here still applies. And even then, I think the bullet points listed here are valuable.

@orgads orgads reopened this Apr 1, 2024
@orgads orgads pinned this issue Apr 1, 2024
@orgads
Copy link
Contributor

orgads commented Apr 1, 2024

I wouldn't consider the project dead at this point, but ok :)

@wdoekes
Copy link
Member

wdoekes commented Apr 2, 2024

Right now? Me neither. But expect the activity to die down again at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants