cppcheck: use --error-exitcode=2 to fail the build on errors

SRombauts · SRombauts · commit 525b7be04173 · 2024-08-21T22:09:44.000+02:00
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -435,7 +435,7 @@ if (SQLITECPP_RUN_CPPCHECK)
         # add a cppcheck target to the "all" target
         add_custom_target(SQLiteCpp_cppcheck
          ALL
-         COMMAND ${CPPCHECK_EXECUTABLE} -j 8 cppcheck --enable=style --quiet ${CPPCHECK_ARG_TEMPLATE} ${PROJECT_SOURCE_DIR}/src
+         COMMAND ${CPPCHECK_EXECUTABLE} -j 8 cppcheck --enable=style --quiet ${CPPCHECK_ARG_TEMPLATE} ${PROJECT_SOURCE_DIR}/src --error-exitcode=2
         )
         execute_process(COMMAND "${CPPCHECK_EXECUTABLE}" --version OUTPUT_VARIABLE CPPCHECK_VERSION OUTPUT_STRIP_TRAILING_WHITESPACE)
         message(STATUS "Found Cppcheck: ${CPPCHECK_EXECUTABLE} (found version ${CPPCHECK_VERSION})")

Original file line number	Diff line number	Diff line change
`@@ -435,7 +435,7 @@ if (SQLITECPP_RUN_CPPCHECK)`
`435`	`435`	`# add a cppcheck target to the "all" target`
`436`	`436`	`add_custom_target(SQLiteCpp_cppcheck`
`437`	`437`	`ALL`
`438`		`- COMMAND ${CPPCHECK_EXECUTABLE} -j 8 cppcheck --enable=style --quiet ${CPPCHECK_ARG_TEMPLATE} ${PROJECT_SOURCE_DIR}/src`
	`438`	`+ COMMAND ${CPPCHECK_EXECUTABLE} -j 8 cppcheck --enable=style --quiet ${CPPCHECK_ARG_TEMPLATE} ${PROJECT_SOURCE_DIR}/src --error-exitcode=2`
`439`	`439`	`)`
`440`	`440`	`execute_process(COMMAND "${CPPCHECK_EXECUTABLE}" --version OUTPUT_VARIABLE CPPCHECK_VERSION OUTPUT_STRIP_TRAILING_WHITESPACE)`
`441`	`441`	`message(STATUS "Found Cppcheck: ${CPPCHECK_EXECUTABLE} (found version ${CPPCHECK_VERSION})")`