Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error message or disable Waiter window #343

Open
vpchung opened this issue Jun 3, 2022 · 1 comment
Open

Add error message or disable Waiter window #343

vpchung opened this issue Jun 3, 2022 · 1 comment
Assignees
Labels
bug Something isn't working major a medium priority item mid-term Timeline: 2-4 months
Milestone

Comments

@vpchung
Copy link
Member

vpchung commented Jun 3, 2022

Is your feature request related to a problem? Please describe.
I was testing out changes on the CSBC/PS-ON DCA, and attempted to generate a template link to understand how the app works. However, something broke in the backend and I didn't notice right away because the error message was hidden under the "Generating link..." window:

dca-error

Describe the solution you'd like
Add a more prominent error message, or disable the Waiter window once an error is encountered.

How important is this feature? Select from the options below:
🌗 Medium (not a huge deal, but it did take me about 5 minutes before realizing that nothing was happening 😅)

When will use cases depending on this become relevant? Select from the options below:
• Mid-term - 2-4 months ?

@vpchung vpchung changed the title Use an Error page Add error message or disable Waiter window Jun 3, 2022
@ychae ychae added bug Something isn't working major a medium priority item mid-term Timeline: 2-4 months labels Jun 7, 2022
@milen-sage milen-sage added this to the DCA UX design milestone Sep 24, 2022
@rrchai
Copy link
Contributor

rrchai commented Oct 4, 2022

AC:
Wrap the function generating the manifest within tryCatch to better capture errors and update waiter once error is encountered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major a medium priority item mid-term Timeline: 2-4 months
Projects
None yet
Development

No branches or pull requests

4 participants