Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should DCA be able to submit manifests with validation warnings #512

Open
afwillia opened this issue Mar 7, 2023 · 4 comments
Open

Should DCA be able to submit manifests with validation warnings #512

afwillia opened this issue Mar 7, 2023 · 4 comments
Assignees

Comments

@afwillia
Copy link
Contributor

afwillia commented Mar 7, 2023

Is your feature request related to a problem? Please describe.
In DCA, you cannot submit a manifest until it has passed validation with schematic. Schematic will return errors and warnings. Should users be able to upload manifests containing warnings?

Screen Shot 2023-03-07 at 11 32 24 AM

@GiaJordan
Copy link

@afwillia you should be able to submit with only warnings returned. Right now, for submission after validation, only errors are checked, so this behavior is not intended

@rrchai
Copy link
Contributor

rrchai commented Mar 7, 2023

Thanks for bringing up the question!

In DCA, you cannot submit a manifest until it has passed validation with schematic. Schematic will return errors and warnings. Should users be able to upload manifests containing warnings?

There was uncertainty whether users could submit manifests with warnings (such as invalid type, invalid cross-manifest checking) to synapse. So the current behavior was designed to avoid storing any possible invalid manifests (the helper message should've covered the only warnings scenario as well though).

If @milen-sage or @GiaJordan agree that we can upload the manifests with warnings ✅, I think we could then proceed to show the button for manifests only containing warnings.

@GiaJordan
Copy link

If @milen-sage or @GiaJordan agree that we can upload the manifests with warnings ✅, I think we could then proceed to show the button for manifests only containing warnings.

Yes, we should proceed. Only errors should prohibit submission @rrchai

@afwillia afwillia self-assigned this Mar 9, 2023
@afwillia
Copy link
Contributor Author

afwillia commented Mar 9, 2023

thanks @GiaJordan and @rrchai - I'll add this to our backlog then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants