-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should DCA be able to submit manifests with validation warnings #512
Comments
@afwillia you should be able to submit with only warnings returned. Right now, for submission after validation, only errors are checked, so this behavior is not intended |
Thanks for bringing up the question!
There was uncertainty whether users could submit manifests with warnings (such as invalid type, invalid cross-manifest checking) to synapse. So the current behavior was designed to avoid storing any possible invalid manifests (the helper message should've covered the only warnings scenario as well though). If @milen-sage or @GiaJordan agree that we can upload the manifests with warnings ✅, I think we could then proceed to show the button for manifests only containing warnings. |
Yes, we should proceed. Only errors should prohibit submission @rrchai |
thanks @GiaJordan and @rrchai - I'll add this to our backlog then! |
Is your feature request related to a problem? Please describe.
In DCA, you cannot submit a manifest until it has passed validation with schematic. Schematic will return errors and warnings. Should users be able to upload manifests containing warnings?
The text was updated successfully, but these errors were encountered: