Merge pull request #80 from jannejava/patch-2

Sammyjo20 · web-flow · commit 05db4d47a0df · 2024-12-03T00:44:16.000Z
Update CompilerOutputFormatter.php
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -19,7 +19,7 @@ jobs:
       fail-fast: true
       matrix:
         os: [ubuntu-latest, windows-latest]
-        php: [8.1, 8.2, 8.3]
+        php: [8.1, 8.2, 8.3, 8.4]
         laravel: ['10.*', '11.*']
         stability: [prefer-lowest, prefer-stable]
         include:
diff --git a/src/Helpers/CompilerOutputFormatter.php b/src/Helpers/CompilerOutputFormatter.php
@@ -28,7 +28,7 @@ public static function getWebpackProgress(string $line): int
 
         preg_match(self::PERCENTAGE_REGEX, $line, $matches, PREG_OFFSET_CAPTURE);
 
-        $percentage = $matches[0][0] ?? null;
+        $percentage = $matches[0][0] ?? '';
 
         return (int)str_replace('%', '', $percentage);
     }
diff --git a/tests/Unit/Support/Zip/Destination/WithSubFolder.zip b/tests/Unit/Support/Zip/Destination/WithSubFolder.zip

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public static function getWebpackProgress(string $line): int`
`28`	`28`
`29`	`29`	`preg_match(self::PERCENTAGE_REGEX, $line, $matches, PREG_OFFSET_CAPTURE);`
`30`	`30`
`31`		`- $percentage = $matches[0][0] ?? null;`
	`31`	`+ $percentage = $matches[0][0] ?? '';`
`32`	`32`
`33`	`33`	`return (int)str_replace('%', '', $percentage);`
`34`	`34`	`}`