Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in #563 break SasView main #573

Open
lucas-wilkins opened this issue Aug 4, 2023 · 1 comment · Fixed by #574
Open

Changes in #563 break SasView main #573

lucas-wilkins opened this issue Aug 4, 2023 · 1 comment · Fixed by #574
Assignees
@lucas-wilkins
Labels
bug

Comments

@lucas-wilkins
Copy link
Contributor

The changes in #563 have caused some issues with DirectModel as it used in SasView (and probably peoples scripts).

The text of #563 says its only an error that will occur outside of SasView and just requires different parameter names, but SasView is affected. Whilst changing the names does remove the error, it results in calculations that are incorrect (in parallelepiped at least, a -> length_a etc).
@lucas-wilkins lucas-wilkins self-assigned this Aug 4, 2023
@lucas-wilkins lucas-wilkins linked a pull request Aug 4, 2023 that will close this issue
Disable name check #574
Merged
@lucas-wilkins lucas-wilkins mentioned this issue Aug 4, 2023
Merged
@lucas-wilkins lucas-wilkins reopened this Aug 16, 2023
@lucas-wilkins
Copy link
Contributor Author

The bug is back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-wilkins lucas-wilkins

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable name check SasView/sasmodels
1 participant
@lucas-wilkins