Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve variables option only goes one level deep. #38

Open
dietergeerts opened this issue Jul 13, 2018 · 2 comments
Open

Resolve variables option only goes one level deep. #38

dietergeerts opened this issue Jul 13, 2018 · 2 comments

Comments

@dietergeerts
Copy link

I have the following SCSS:

/// @group color-colors
/// @type Color
$yellow: #ffde17 !default;

/// @group color-theme-colors
/// @type Color
$warning: $yellow !default;

/// @group color-subject-status-colors
/// @type Color
/// @link needs-review
$subject-status-needs-review: $warning !default;

And this resolves to:

$yellow: #ffde17;
$warning: #ffde17;
$subject-status-needs-review: $yellow ;

It should go down until the value isn't a variable anymore

@mariusroed
Copy link

mariusroed commented May 31, 2019

I have the same issue. Need to support multiple levels. Ex.

$colors: (
    primary: (
        base: #d81939,
        dark: #ae0823
    ),
    secondary: (
        base: #003251, // #003d50
        dark: #002a3a
    ),
    neutral: (
        xxxlight: #f1f1f1,
        xxlight: #e3e3e3,
        xlight: #d8d8d8,
        light: #c3c3c3,
        base: #909090,
        dark: #626363,
        xdark: #424141
    )
);

Is this something which will be supported? Or just something I'm doing wrong?

@pascalduez
Copy link
Member

Is this something which will be supported? Or just something I'm doing wrong?

Yes, looks like we want to support this.

PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants