Skip to content

Commit 5bd4d94

Browse files
authored
Merge pull request #82 from Scaffold-Stark/fix/miscellaneous-fixes
fix: miscellaneous fixes
2 parents 4c8b7c4 + b5b7674 commit 5bd4d94

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

docs/deploying/deploy-production.mdx

+13-10
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ Before deploying to production, ensure you have the correct versions of all depe
1313

1414
```bash
1515
# Check versions
16-
node --version # >= v18.17
17-
starknet-devnet --version # 0.2.3
18-
scarb --version # 2.9.2
19-
snforge --version # 0.34.0
16+
node --version # >= v18.17
17+
starknet-devnet --version # 0.2.3
18+
scarb --version # 2.9.2
19+
snforge --version # 0.34.0
2020
```
2121

2222
:::warning
@@ -35,7 +35,9 @@ Delete the debug page and its components:
3535
rm -rf packages/nextjs/app/debug
3636
```
3737

38-
#### 2. Remove the debug route from your navigation if you've added it manually in any of your components.
38+
#### 2. Remove the debug route from your navigation
39+
40+
If you've added it manually in any of your components, you can remove the debug route from it.
3941

4042
:::tip Hint
4143
If you want to keep the debug features for development while removing them from production, you can use environment-based conditional rendering:
@@ -106,13 +108,14 @@ eslint: {
106108
107109
These settings control how your application handles TypeScript and ESLint errors during the build process:
108110
109-
- When NEXT_PUBLIC_IGNORE_BUILD_ERROR is set to "true":
111+
- When `NEXT_PUBLIC_IGNORE_BUILD_ERROR` environment variable is set to `true`:
110112
- TypeScript type checking errors won't stop your build
111113
- ESLint warnings and errors won't prevent deployment
112114
- This is useful when: - You're in rapid development and want to test deployments despite minor type issues - You're dealing with third-party dependencies that have type conflicts - You're migrating a JavaScript project to TypeScript and want to deploy while still fixing type issues
113-
:::warning
114-
While these settings can help you deploy quickly, it's recommended to fix all TypeScript and ESLint errors before deploying to production. Ignoring these errors might hide potential bugs or issues in your code.
115-
:::warning
115+
116+
:::warning
117+
While these settings can help you deploy quickly, it's recommended to fix all TypeScript and ESLint errors before deploying to production. Ignoring these errors might hide potential bugs or issues in your code.
118+
:::warning
116119
117120
#### 2. Webpack optimization for compatibility:
118121
@@ -227,7 +230,7 @@ const nextConfig = {
227230
228231
## 6. Production Deployment Checklist
229232
230-
Before deploying to production, ensure you have:
233+
Before deploying to production, you can follow the following checklist to make sure you have the most optimum build:
231234
232235
- [ ] Removed or conditionally rendered debug packages
233236
- [ ] Configured production environment variables

docs/eth-stark/eth-stark.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
sidebar_position: 6
33
---
44

5-
# 🚩 (Coming Soon) Using Scaffold Stark with Ethereum Contracts
5+
# 🚩 Using Scaffold Stark with Ethereum Contracts
66

77
[Scaffold-ETH-Stark](https://github.com/Scaffold-Stark/scaffold-eth-stark) is an innovative toolkit that combines the capabilities of Scaffold-Stark and Scaffold-ETH, providing a unified solution for building decentralized applications (dapps) on both Starknet and EVM-compatible blockchains.
88

docs/quick-start/starknet-devnet-with-asdf.mdx

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
# Starknet Devnet - Installation with asdf
1+
# Setting up `starknet-devnet` with `asdf`
22

3-
This document provides a guide to install **Starknet Devnet** using `asdf`, a Rust-based tool for developers. Below, you'll find instructions for installation using `asdf`.
3+
This document provides a guide to install **Starknet Devnet** using `asdf`, a Rust-based tool for developers. Below, you'll find instructions for installation using `asdf`. This method is preferred since it will be easier to stay tune to updates and sync in case there are major changes.
44

55
## Requirements
66

0 commit comments

Comments
 (0)