Requested changes from review

Schmidor · Aug 30, 2024 · 831aa44 · 831aa44
1 parent c0e4adc
commit 831aa44
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/.../javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp b/.../javafx.web/src/main/native/Source/WebCore/platform/graphics/java/GraphicsContextJava.cpp
@@ -1029,7 +1029,7 @@ void GraphicsContextJava::didUpdateState(GraphicsContextState& state)
             float clr = 0.0f;
             platformContext()->rq().freeSpace(32)
             << (jint)com_sun_webkit_graphics_GraphicsDecoder_SETSHADOW
-            << clr << clr << clr << clr << clr << clr << clr;;
+            << clr << clr << clr << clr << clr << clr << clr;
         }
     }
 

diff --git a/modules/javafx.web/src/test/java/test/javafx/scene/web/ShadowTest.java b/modules/javafx.web/src/test/java/test/javafx/scene/web/ShadowTest.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -30,11 +30,8 @@
 import javafx.scene.web.WebEngineShim;
 import org.junit.Test;
 
-import javax.imageio.ImageIO;
 import java.awt.Color;
 import java.awt.image.BufferedImage;
-import java.io.File;
-import java.io.IOException;
 
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertTrue;
@@ -62,11 +59,11 @@ public class ShadowTest extends TestBase {
 
                 int redShadowCnt = 0;
                 int noShadowCnt = 0;
-                for(int x = 0; x < 100; x++){
-                    for(int y = 0; y < 200; y++){
+                for (int x = 0; x < 100; x++) {
+                    for (int y = 0; y < 200; y++) {
                         Color pixelColor = new Color(img.getRGB(x, y), true);
-                        if(isColorsSimilar(Color.RED, pixelColor, 1)){
-                            if(y < 100){
+                        if (isColorsSimilar(Color.RED, pixelColor, 1)) {
+                            if (y < 100) {
                                 redShadowCnt++;
                             } else {
                                 noShadowCnt++;