-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot select effect color on KDE #201
Comments
Hi there! Thanks for the report! Sadly, I cannot reproduce this on my end. It could be due to an issue with your GPU (I only have an NVidia card for testing). Do you have by any chance some coding experience so that we could try to debug this on your end? The shaders should be stored in |
I don't have coding experience, but I guess we could still try. I found the shader files. What do I need to edit? |
I do feel comfortable editing these shaders, and I have the same issue. What would you like me to do? |
Well, first I would try to check which shader is actually used. For this, you could find the main() {
setOutputColor(vec4(1.0, 0.0, 0.0, 1.0));
return;
... If you now save this file, select a different effect in the system settings and the re-select the fire effect, you should get red boxes whenever you open or close a window. If nothing changed, you should try the same with the other fire shader. If the windows just open and close instantaneously, you most likely have a typo in the GLSL code. To find these, you should have journalctl -f -o cat always running in a terminal. This will print any GLSL errors whenever you (re-)select the effect in the system settings. If you see the red boxes, you could try to print some of the values in the shader. For example, you could print the UV coordinates. These are computed right at the start of the main and you could set them as output color right after the computation: void main() {
// Get a noise value which moves vertically in time.
vec2 uv = iTexCoord.st * uSize / vec2(400, 600) / uScale;
uv.y += uProgress * uDuration * uMovementSpeed;
setOutputColor(vec4(uv, 0.0, 1.0));
return;
... This should now produce no red boxes but red-green-yellow gradients. Then there are some examples at the bottom of the shader file (https://github.com/Schneegans/Burn-My-Windows/blob/main/resources/shaders/fire.frag#L129) which you could try. If you play around a bit, you should get an idea what part does not work. I somehow suspect that there is some issue with the noise... |
Btw, do you by any chance also experience #199? |
The wisp effect seems to work, but there is no color, i.e. the wisps are black. The color selector in the settings is empty, (as is the gradient selector in the fire effect settings btw). I do not have the abnormalities in the border. The shader used is When I add the setOutputColor line and re-apply the fire effect, a new error is shown in the journal: This happens when I move the line lower and lower until the code looks like this:
Starting at
until the bottom, the error is Windows now open and close without an animation. After removing lines 70-74 from Now I removed the the extra setOutputColor line from the shader, and I got a nice animation, not suprisingly without the fire. Here's a gif. Apparently the problem is in the I am using Plasma 5.25.5; my graphics card is a GeForce RTX 2060 Super. What's next :) |
Well, that's interesting. It seems like the color picker could be the issue. How does it behave?Can you select a different color? Does it always reset to black somehow? |
I just remembered this discussion: #177 Maybe that's the reason? |
Yes, that did it. In Kubuntu the package is called libkf5widgetsaddons-dev, and after installing that I can select colors and revert them to default. Now the fire looks fine. Thanks a lot. Like vitotankian in #177 I was considering moving to Gnome for the burning windows alone :) |
Great! I'll add a corresponding note to the README and the pages on store.kde.org. I'll also pin this issue so that others may find it more easily. TLDR; If the color picker widgets do not work for you, you may have to install a package called If you are on Plasma 6 already, the package may be called differently, like |
Gonna add a comment for Gentoo/from-source distro users, you need to enable the QT designer flag ( |
Instead of the effect the window is displayed as a black box and then (dis)appears after the effect duration.
As suggested on reddit I tried checking the output of "journalctl -f -o cat". This seems to be the error hat comes up when a windows is opened/closed:
Operating System: KDE neon 5.25
KDE Plasma Version: 5.25.4
KDE Frameworks Version: 5.96.0
Qt Version: 5.15.5
Kernel Version: 5.15.0-46-generic (64-bit)
Graphics Platform: X11
Processors: 12 × AMD Ryzen 5 3600 6-Core Processor
Memory: 15,6 GiB of RAM
Graphics Processor: Radeon RX 5500 XT
Manufacturer: Gigabyte Technology Co., Ltd.
Product Name: B550 AORUS PRO
The text was updated successfully, but these errors were encountered: