Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OnyxColorSchemeDialog to use internal onyx components #2384

Open
13 tasks
larsrickert opened this issue Dec 19, 2024 · 0 comments
Open
13 tasks

Adjust OnyxColorSchemeDialog to use internal onyx components #2384

larsrickert opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise

Comments

@larsrickert
Copy link
Collaborator

Why?

We currently already have the OnyxColorSchemeDialog component that can be used to switch between auto, light and dark mode.

We want to update its implementation internally to use the OnyxModalDialog and OnyxCard component to prevent custom/duplicated code.

Open questions / TODOs

No response

Depends on

Design

Storybook

Acceptance criteria

  • the OnyxModalDialog is used where "Change appearance" is the headline and "Select the appearance of the application:" becomes the subtitle
  • the OnyxCard is used for the auto, light and dark selectable option

Implementation details

No response

Reference implementations

No response

Applicable ARIA Pattern

No response

Definition of Done

  • The following component requirements are implemented:

    • density
    • example usage added to apps/demo-app/src/views/HomeView.vue
  • Should be covered by tests:

    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • Make sure, that

    • follow-up tickets were created if necessary
    • updated version + documentation is deployed
    • Storybook can show the feature
    • Storybook code snippet of new/changed examples are checked that they are generated correctly
    • Namings are aligned with Figma

Approval

Storybook

  • Checked and approved by
    • designer
    • dev
@larsrickert larsrickert added 0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise labels Dec 19, 2024
@larsrickert larsrickert self-assigned this Dec 19, 2024
@larsrickert larsrickert added this to onyx Dec 19, 2024
@github-project-automation github-project-automation bot moved this to New in onyx Dec 19, 2024
@larsrickert larsrickert moved this from New to Backlog in onyx Dec 19, 2024
@mj-hof mj-hof added this to the Product improvements milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-refinement All issues that can or need to be estimated in our next refinement dev Requires technical expertise
Projects
Status: Backlog
Development

No branches or pull requests

2 participants