Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement smart autofocus #2394

Open
2 of 15 tasks
JoCa96 opened this issue Dec 20, 2024 · 0 comments
Open
2 of 15 tasks

Implement smart autofocus #2394

JoCa96 opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
dev Requires technical expertise
Milestone

Comments

@JoCa96
Copy link
Collaborator

JoCa96 commented Dec 20, 2024

Why?

As a poweruser I want to work through forms and pages using the keyboard without the need for tabbing, so that I can work quickly.

Acceptance criteria

  • All OnyxFormElements support the property autofocus
  • autofocus only has a one-time effect on mounted
  • When a page, dialog, or page content is mounted which includes an OnyxFormElement with an autofocus attribute, this element is focused
  • the description is updated to explain this behavior and warns that the usage can disrupt the user experience when used incorrectly

Implementation details

  • when autofocus is set to true:
    • in onMounted it is checked if the input is focused otherwise focus is set manually

Definition of Done

  • The following component requirements are implemented:

    • example usage added to apps/demo-app/src/views/HomeView.vue
  • Should be covered by tests:

    • functional tests (Playwright or unit test)
    • visual tests (Playwright screenshots)
  • Make sure, that

    • follow-up tickets were created if necessary
    • updated version + documentation is deployed
    • Storybook can show the feature
    • Storybook code snippet of new/changed examples are checked that they are generated correctly
    • Namings are aligned with Figma

Approval

Storybook
Documentation

  • Checked and approved by
    • dev
@JoCa96 JoCa96 added the dev Requires technical expertise label Dec 20, 2024
@JoCa96 JoCa96 added this to onyx Dec 20, 2024
@github-project-automation github-project-automation bot moved this to New in onyx Dec 20, 2024
@JoCa96 JoCa96 moved this from New to Backlog in onyx Jan 8, 2025
@JoCa96 JoCa96 added the 0-refinement All issues that can or need to be estimated in our next refinement label Jan 8, 2025
@mj-hof mj-hof removed the 0-refinement All issues that can or need to be estimated in our next refinement label Jan 8, 2025
@mj-hof mj-hof assigned ChristianBusshoff and unassigned JoCa96 Jan 8, 2025
@mj-hof mj-hof moved this from Backlog to Ready in onyx Jan 8, 2025
@mj-hof mj-hof added this to the Inputs milestone Jan 8, 2025
@ChristianBusshoff ChristianBusshoff moved this from Ready to In Progress in onyx Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise
Projects
Status: In Progress
Development

No branches or pull requests

3 participants