Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement browser compatibility linting #83

Closed
8 tasks done
larsrickert opened this issue Jan 9, 2024 · 3 comments
Closed
8 tasks done

Implement browser compatibility linting #83

larsrickert opened this issue Jan 9, 2024 · 3 comments
Assignees
Labels
dev Requires technical expertise

Comments

@larsrickert
Copy link
Collaborator

larsrickert commented Jan 9, 2024

Open Questions/To-dos

Why?

Check if we can e.g. setup eslint (or a similar tool) to check/warn for Web API support / browser compatibility in our code.
So that we are notified when we try to use a Web API that is not supported by X percent of browsers.

Also look into the necessity of polyfills etc for supporting older browsers in the company

Acceptance criteria

  • Pipeline should check browser support of the web APIs we use
  • Define a list of relevant browser
  • If there are issues that get out of scope, create tickets
  • Update the Docs to reflect which browsers + versions are supported (ideally it is connected to a browserlists file)

Definition of Done

Approval

Implementation details

  • Info: ask A.S. from the department "Workplace Platform Design" about which relevant browsers & versions we have to support
@larsrickert larsrickert added this to the Setup milestone Jan 9, 2024
@mj-hof mj-hof added the dev Requires technical expertise label Jan 9, 2024
@mj-hof mj-hof changed the title Check if we can setup tooling for web-api-support checks (CanIUse) Define setup tooling for web-api-support checks (CanIUse) Feb 26, 2024
@oemueller oemueller self-assigned this Oct 10, 2024
@oemueller
Copy link
Contributor

Proposed browserlist: https://browsersl.ist/#q=%3E+0.5%25%2C+last+2+versions%2C+Firefox+ESR%2C+not+dead

@oemueller
Copy link
Contributor

oemueller commented Oct 11, 2024

with npx browserslist we can get a list of supported browsers -> based on that we can render a table of all supported browsers in the Docs, also possible with JS API
const browsers = browserslist(
["> 0.5%", "last 2 versions", "Firefox ESR", "not dead", "not op_mini all", "not KaiOS < 4.0"],
// {
// stats: opts.stats,
// path: opts.file,
// env: opts.env,
// },
);

@oemueller
Copy link
Contributor

oemueller commented Oct 15, 2024

Desktop browser requirements: Edge, Safari (last 2 Versions), Firefox ESR (Source: Workplace Platform Design)

Mobile requirements: iOS Safari (last 2 Versions), Chrome for Android (last 2 Versions)

Approved by responsible people of the departments.

larsrickert added a commit that referenced this issue Oct 28, 2024
…ed browsers (#1956)

Relates to #83 

Add browser lint and docs with supported browsers

---------

Co-authored-by: Oliver Müller <[email protected]>
Co-authored-by: Lars Rickert <[email protected]>
@JoCa96 JoCa96 closed this as completed Oct 30, 2024
@JoCa96 JoCa96 changed the title Define setup tooling for web-api-support checks (CanIUse) Implement browser compatibility linting Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise
Projects
Status: Done
Development

No branches or pull requests

4 participants