Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ABM tests #1067

Open
2 tasks done
reneSchm opened this issue Jul 10, 2024 · 2 comments
Open
2 tasks done

Improve ABM tests #1067

reneSchm opened this issue Jul 10, 2024 · 2 comments
Assignees
@khoanguyen-dev
Labels
class::discussion Used for discussions on software and model . class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model.

Comments

@reneSchm
Copy link
Member

Motivation / Current Behaviour

The current ABM coverage is okay, but some of the tests need to be improved. Most importantly, many tests do not have a clear test case.

Enhancement description

The steps might be:

  1. Find out the test case for each test and document it.
  2. Decide whether to keep the test, or remove/extend/split it

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@reneSchm reneSchm added class::discussion Used for discussions on software and model . loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. class::improvement Cleanup that doesn't affect functionality labels Jul 10, 2024
@reneSchm
Copy link
Member Author

Examples:

  • TestWorld.evolveMigration is huge, and contains several test cases. It should be split up.
  • Several tests in TestMigrationRules use rng without mocking.
  • We could think about adding fuzzing or more test cases to some setter/getter tests like TestPerson.setGetAssignedLocation, as they mostly test only one value.

@reneSchm reneSchm moved this from Product Backlog 📕 to Next up 🆙 in MEmilio: Agent-Based-Model Development Jul 10, 2024
@reneSchm reneSchm mentioned this issue Jul 11, 2024
Merged
11 tasks
@khoanguyen-dev khoanguyen-dev moved this from Next up 🆙 to Sprint Backlog 🏃‍♂️ in MEmilio: Agent-Based-Model Development Aug 8, 2024
@khoanguyen-dev khoanguyen-dev self-assigned this Aug 14, 2024
@khoanguyen-dev
Copy link
Member

We also need to add all checks for different VirusVariants in check_constraints() of parameters.h

@khoanguyen-dev khoanguyen-dev linked a pull request Oct 31, 2024 that will close this issue
1067 improve abm tests #1141
Open
12 tasks
@reneSchm reneSchm removed a link to a pull request Nov 12, 2024
1067 improve abm tests #1141
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khoanguyen-dev khoanguyen-dev

Labels
class::discussion Used for discussions on software and model . class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model.
Projects
MEmilio: Agent-Based-Model Development
Status: Review 🕵️‍♂️
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khoanguyen-dev @reneSchm