TEMP COMMIT: add debug statements

Author: AayushSabharwal

lib/ModelingToolkitBase/src/utils.jl

@@ -767,6 +767,8 @@ function (::OperatorIsAtomic{O})(ex::SymbolicT) where {O}
     end
 end
 
+__DEBUG_CV::Bool = false
+
 """
     $(TYPEDSIGNATURES)
 
@@ -782,11 +784,13 @@ can be checked using `check_scope_depth`.
 This function should return `nothing`.
 """
 function collect_vars!(unknowns::OrderedSet{SymbolicT}, parameters::OrderedSet{SymbolicT}, expr::SymbolicT, iv::Union{SymbolicT, Nothing}, ::Type{op} = Symbolics.Operator; depth = 0) where {op}
+    __DEBUG_CV && @info "collect_vars!" expr
     Moshi.Match.@match expr begin
         BSImpl.Const() => return
         BSImpl.Sym() => return collect_var!(unknowns, parameters, expr, iv; depth)
         _ => nothing
     end
+    __DEBUG_CV && @info "No early exit"
     vars = OrderedSet{SymbolicT}()
     SU.search_variables!(vars, expr; is_atomic = OperatorIsAtomic{op}())
     for var in vars
@@ -799,6 +803,7 @@ function collect_vars!(unknowns::OrderedSet{SymbolicT}, parameters::OrderedSet{S
             _ => collect_var!(unknowns, parameters, var, iv; depth)
         end
     end
+    __DEBUG_CV && @info "Exit collect_vars!" expr
     return nothing
 end
 
@@ -846,6 +851,7 @@ end
 function collect_vars!(
         unknowns::OrderedSet{SymbolicT}, parameters::OrderedSet{SymbolicT}, expr, iv::Union{SymbolicT, Nothing}, ::Type{op} = Symbolics.Operator; depth = 0
     ) where {op}
+    __DEBUG_CV && @info "Fallback" expr
     return nothing
 end
 
@@ -857,6 +863,7 @@ Add `var` to `unknowns` or `parameters` appropriately, and search through any ex
 in known metadata of `var` using `collect_vars!`.
 """
 function collect_var!(unknowns::OrderedSet{SymbolicT}, parameters::OrderedSet{SymbolicT}, var::SymbolicT, iv::Union{SymbolicT, Nothing}; depth = 0)
+    __DEBUG_CV && @info "Enter" var
     isequal(var, iv) && return nothing
     if Symbolics.iswrapped(var)
         error(
@@ -872,7 +879,10 @@ function collect_var!(unknowns::OrderedSet{SymbolicT}, parameters::OrderedSet{Sy
         )
     end
     arr, isarr = split_indexed_var(var)
-    check_scope_depth(getmetadata(arr, SymScope, LocalScope())::AllScopes, depth) || return nothing
+    if !check_scope_depth(getmetadata(arr, SymScope, LocalScope())::AllScopes, depth)
+        __DEBUG_CV && @info "Exit scope" var
+        return nothing
+    end
     var = setmetadata(var, SymScope, LocalScope())
     if iscalledparameter(var)
         callable = getcalledparameter(var)
@@ -885,6 +895,7 @@ function collect_var!(unknowns::OrderedSet{SymbolicT}, parameters::OrderedSet{Sy
     end
     # Add also any parameters that appear only as defaults in the var
     if hasdefault(var) && (def = getdefault(var)) !== missing
+        __DEBUG_CV && @info "Found default" def
         if def isa SymbolicT
             collect_vars!(unknowns, parameters, def, iv)
         elseif def isa Num

lib/ModelingToolkitBase/test/extensions/dynamic_optimization.jl

@@ -328,7 +328,16 @@ end
         D(v) ~ (T_interp(t) - drag(h, v)) / m - gravity(h),
         D(m) ~ -T_interp(t) / c,
     ]
-    @mtkcompile rocket_ode = System(eqs, t)
+    ModelingToolkitBase.__DEBUG_CV = true
+    rocket_ode = try
+        @mtkcompile rocket_ode = System(eqs, t)
+    catch
+        rethrow()
+    finally
+        ModelingToolkitBase.__DEBUG_CV = false
+    end
+    @info Symbolics.getdefaultval(m)
+    @info parameters(rocket_ode)
     interpmap = Dict(T_interp => ctrl_to_spline(jsol.input_sol, CubicSpline))
     u0map = [h => h₀, v => 0]
     pmap = [

lib/ModelingToolkitBase/test/odesystem.jl

@@ -850,7 +850,7 @@ Set(unknowns(new_sys2)) == Set(
 
 let # Issue https://github.com/SciML/ModelingToolkit.jl/issues/2322
     @parameters a = 10 b = a / 10 c = a / 20
-
+    @info Symbolics.getdefaultval(b)
     Dt = D
 
     @variables x(t) = 1 z(t)
@@ -859,9 +859,14 @@ let # Issue https://github.com/SciML/ModelingToolkit.jl/issues/2322
         Dt(x) ~ -b * (x - z),
         0 ~ z - c * x,
     ]
-
-    sys = System(eqs, t; name = :kjshdf)
-
+    ModelingToolkitBase.__DEBUG_CV = true
+    sys = try
+        System(eqs, t; name = :kjshdf)
+    catch
+        rethrow()
+    finally
+        ModelingToolkitBase.__DEBUG_CV = false
+    end 
     sys_simp = mtkcompile(sys)
 
     @test a ∈ keys(ModelingToolkitBase.initial_conditions(sys_simp))