Skip to content

Symbol map not working for initial_conditions argument #4232

@TorkelE

Description

@TorkelE
using ModelingToolkitBase
using ModelingToolkitBase: t_nounits as t, D_nounits as D
@variables X(t)
@parameters p d
eqs = [
    D(X) ~ p - d*X
]
@mtkbuild sys = System(eqs, t; initial_conditions = [p => 1.0]) # Fine
@mtkbuild sys = System(eqs, t; initial_conditions = [X => 1.0]) # Fine
@mtkbuild sys = System(eqs, t; initial_conditions = [:p => 1.0]) # Error
@mtkbuild sys = System(eqs, t; initial_conditions = [:X => 1.0]) # Error
ERROR: MethodError: no method matching validate_atomic_array_key(::Symbol)
The function `validate_atomic_array_key` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  validate_atomic_array_key(::SymbolicUtils.BasicSymbolicImpl.var"typeof(BasicSymbolicImpl)"{SymReal})
   @ ModelingToolkitBase ~/.julia/packages/ModelingToolkitBase/TWtK0/src/atomic_array_dict.jl:40

Stacktrace:
 [1] setindex!(dd::ModelingToolkitBase.AtomicArrayDict{…}, v::SymbolicUtils.BasicSymbolicImpl.var"typeof(BasicSymbolicImpl)"{…}, k::Symbol)
   @ ModelingToolkitBase ~/.julia/packages/ModelingToolkitBase/TWtK0/src/atomic_array_dict.jl:62
 [2] defsdict
   @ ~/.julia/packages/ModelingToolkitBase/TWtK0/src/systems/system.jl:383 [inlined]
 [3] System(eqs::Vector{…}, iv::SymbolicUtils.BasicSymbolicImpl.var"typeof(BasicSymbolicImpl)"{…}, dvs::Vector{…}, ps::Vector{…}, brownians::Vector{…}; constraints::Vector{…}, noise_eqs::Nothing, jumps::Vector{…}, costs::Vector{…}, consolidate::Function, preface::Any, tstops::Any, observed::Vector{…}, bindings::ModelingToolkitBase.AtomicArrayDict{…}, initial_conditions::Vector{…}, guesses::ModelingToolkitBase.AtomicArrayDict{…}, systems::Vector{…}, initialization_eqs::Vector{…}, continuous_events::Vector{…}, discrete_events::Vector{…}, connector_type::Nothing, assertions::Dict{…}, metadata::Base.ImmutableDict{…}, gui_metadata::Nothing, is_dde::Nothing, inputs::OrderedCollections.OrderedSet{…}, outputs::OrderedCollections.OrderedSet{…}, tearing_state::Nothing, ignored_connections::Nothing, parent::Nothing, state_priorities::ModelingToolkitBase.AtomicArrayDict{…}, irreducibles::ModelingToolkitBase.AtomicArraySet{…}, description::String, name::Symbol, discover_from_metadata::Bool, initializesystem::Nothing, is_initializesystem::Bool, is_discrete::Bool, checks::Bool, __legacy_defaults__::Nothing)
   @ ModelingToolkitBase ~/.julia/packages/ModelingToolkitBase/TWtK0/src/systems/system.jl:498
 [4] System(eqs::Vector{Equation}, iv::Num; kwargs::@Kwargs{name::Symbol, initial_conditions::Vector{Pair{Symbol, Float64}}})
   @ ModelingToolkitBase ~/.julia/packages/ModelingToolkitBase/TWtK0/src/systems/system.jl:758
 [5] top-level scope
   @ ~/.julia/packages/ModelingToolkitBase/TWtK0/src/deprecations.jl:9
 [6] macro expansion
   @ ~/.julia/packages/ModelingToolkitBase/TWtK0/src/systems/abstractsystem.jl:2571 [inlined]
Some type information was truncated. Use `show(err)` to see complete types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions