Skip to content

fix: avoid false positives in consistency check #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AayushSabharwal wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −2
Open

fix: avoid false positives in consistency check #4150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
542783c
fix: avoid false positives in consistency check
AayushSabharwal Jan 13, 2026
7f8ab88
test: add missing equation in test case
AayushSabharwal Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/ModelingToolkitBase/test/stream_connectors.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,6 +510,7 @@ function TwoFluidSystem(; name)
connect(fluid_b, source_b.H)
connect(source_b.H, pipe_b.HA)
connect(pipe_b.HB, volume_b.H)
source_a.H.dm ~ 0
]

return System(eqs, t, vars, pars; name, systems)
Expand Down
4 changes: 2 additions & 2 deletions src/systems/systemstructure.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,13 +233,13 @@ function _mtkcompile!(
union!(inputs, disturbance_inputs)
state = ModelingToolkit.inputs_to_parameters!(state, discrete_inputs, OrderedSet{SymbolicT}())
state = ModelingToolkit.inputs_to_parameters!(state, inputs, outputs)
StateSelection.trivial_tearing!(state)
sys, mm = ModelingToolkit.alias_elimination!(state; fully_determined, kwargs...)
if check_consistency
fully_determined = StateSelection.check_consistency(
state, orig_inputs; nothrow = fully_determined === nothing
)
end
StateSelection.trivial_tearing!(state)
sys, mm = ModelingToolkit.alias_elimination!(state; fully_determined, kwargs...)
# This phrasing avoids making the `kwcall` dynamic dispatch due to the type of a
# keyword (`mm`) being non-concrete
if mm isa CLIL.SparseMatrixCLIL{BigInt, Int}
Expand Down
Loading