Skip to content

Address failing Ruff tests #297

@ukmo-ccbunney

Description

@ukmo-ccbunney

📰 Custom Issue

Following a QA refresh of this repo, the following Ruff checks are failing (and are currently being ignored in pyproject.toml):

### Flake8-builtins
- [x] `A001`   builtin-variable-shadowing
- [ ] `A002`   undocumented-public-method
### Flake8-annotations
- [ ] `ANN001`   missing-type-function-argument
- [ ] `ANN002`   missing-type-args
- [ ] `ANN003`   missing type annotation for `**kwargs`
- [ ] `ANN201`   missing-return-type-undocumented-public-function
- [ ] `ANN202`   missing-return-type-private-function
- [ ] `ANN204`   missing-return-type-special-method
- [ ] `ANN205`   missing-return-type-static-method
- [ ] `ANN206`   missing-return-type-class-method
### Flake8-unused-arguments
- [ ] `ARG001`   unused-function-argument
- [ ] `ARG002`   Unused method argument
- [ ] `ARG003`   unused-class-method-argument
- [ ] `ARG004`   unused-static-method-argument
### Flake8-bugbear
- [ ] `B028`   no-explicit-stacklevel
### Flake8-comprehensions
- [ ] `C408`   unnecessary-collection-call
- [ ] `C901`   complex-structure
### pydocstyle
- [ ] `D100`   undocumented-public-module
- [ ] `D101`   undocumented-public-class
- [ ] `D102`   undocumented-public-method
- [ ] `D103`   undocumented-public-function
- [ ] `D105`   undocumented-magic-method
- [ ] `D200`   fits-on-one-line
- [ ] `D205`   blank-line-after-summary
- [ ] `D401`   non-imperative-mood
### Flake8-datetimez
- [ ] `DTZ002`   call-datetime-today
### pycodestyle
- [ ] `E501`   line-too-long
### Flake8-errmsg
- [ ] `EM101`   raw-string-in-exception
### Eradicate
- [ ] `ERA001`   commented-out-code
### Flake8-fixme
- [ ] `FIX002`   Line contains TODO, consider resolving the issue
### flake8-import-conventions
- [ ] `ICN001`   unconventional-import-alias
### pep8-naming
- [ ] `N801`   invalid-class-name
- [ ] `N802`   invalid-function-name
### numpy
- [ ] `NPY002`   numpy-legacy-random
### pylint
- [ ] `PLR0912`   Too many branches
- [ ] `PLR5501", # collapsible-else-if; Preserve readability of TODO block in `convert` method
### flake8-pytest-style
- [ ] `PT009`   pytest-unittest-assertion
- [ ] `PT027`   pytest-unittest-raises-assertion
### flake8-return
- [ ] `RET503`   implicit-return
### flake8-bandit
- [ ] `S101`   Assert used
### flake8-simplify
- [ ] `SIM102`   collapsible-if
- [ ] `SIM108`   if-else-block-instead-of-if-exp
### flake8-todos
- [ ] `TD002`   Missing author in TODO; try
- [ ] `TD003`   Missing issue link on the line following this TODO
- [ ] `TD004`   Missing colon in TODO
### tryceratops
- [ ] `TRY003`   raise-vanilla-args
- [ ] `TRY004`   type-check-without-type-error
### pyupgrade
- [ ] `UP008`   super-call-with-parameter

These should be address and removed from the ignore list if possible.

Metadata

Metadata

Assignees

No one assigned

    Labels

    New: IssueHighlight a new community raised "generic" issue

    Type

    No type

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions