Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement #250

Open
jefleponot opened this issue Mar 4, 2015 · 6 comments
Open

Enhancement #250

jefleponot opened this issue Mar 4, 2015 · 6 comments

Comments

@jefleponot
Copy link

Hello Zarkonnen and everybody,

I would like to have on "se-builder" more commands (but se-builder would always remain userfriendly and pleasant to use - not like selenium ide top-heaving)

  • rightClickElement [locator] : usefull for contentMenu
  • uploadFile [filename]
  • resizeWindow : usefull for screenshots
  • switchToParentFrame : usefull for navigation
  • waitForElementVisible : useful for screenshots
  • verifyElementVisible : useful for browsing
  • assertElementVisible : useful for browsing
  • printWindowsName : usefull to build browsing
  • printChildFramesName : usefull to build browsing
  • includeJs : usefull for add jquery library
  • injectJs : usefull for using include library

it would be nice to add 2 attributes into commands :

  • a comment to explain that is supposed to happen
  • a flag to test, on each step of browsing, a verification command.

example :
{
"type": "verifyTextPresent",
"text": "timeout connection",
"negated": true
},

What do you think about that ?
Which commands you agree to be added ?

Best regards
Jef

@Zarkonnen
Copy link

  • rightClickElement, uploadFile, resizeWindow, switchToParentFrame - yes, definitely!
  • xElementVisible is technically against the way Selenium 2 is meant to work using implicit waits...
  • printX - Would just be a shortcut for storeX, print, so I'm not keen.
  • include&injectJS - Ooh, that's quite interesting. Might be tricky to get right, but I definitely like.
  • comments - This is actually already available, it's just really obscure and needs to be less so. If you click on the number of a step, you can edit that number into a name/comment.
  • verification on each step - I think this is too specific a feature, and can be emulated by just putting the verification steps into the script.

Anyway, I hope this makes sense. I'll see that I can put some of the low-hanging fruit on this list into 2.3.2.

@Zarkonnen Zarkonnen added this to the Builder 2.3.2 milestone Apr 17, 2015
@jefleponot
Copy link
Author

Hello Zarkonnen and everybody,

Thank you for answering.
It's true that I haven't seen how to edit the comment step_name.

I will start to develop "rightClickElement, uploadFile, resizeWindow, switchToParentFrame" features but I'm not good in XUL code.

Could you give me some tutorial link ?
How to test program to differents versions of ff ?
Could I insert some slimerjs codes ?

Regards
jef

@Zarkonnen
Copy link

Conveniently, you don't have to know any XUL, because it's all plain JS. :D

The important thing is that playback of new steps has to work the same across local and remote playback. So you could use slimerjs, but I'm a bit worried that it will have different semantics.

I frankly don't really bother with older versions of Firefox - as long as it works correctly in local playback with the most recent release version, that's fine.

A good place to start for info may be the contribution notes on the wiki: https://github.com/SeleniumBuilder/se-builder/wiki/Contribution-Notes

@Zarkonnen
Copy link

Oh, and I've just implemented resizeWindow. :)

@jefleponot
Copy link
Author

lol

@Zarkonnen
Copy link

Moving these to Milestone 2.4 for now.

@Zarkonnen Zarkonnen modified the milestones: Builder 2.4, Builder 2.3.2 Apr 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants