better rule integration

Author: corevo

.eslintrc.js

@@ -6,7 +6,7 @@ module.exports = {
     jest: true,
     webextensions: true,
   },
-  extends: ['plugin:react/recommended'],
+  extends: ['eslint:recommended', 'plugin:react/recommended', 'prettier'],
   parser: 'babel-eslint',
   parserOptions: {
     ecmaFeatures: {
@@ -16,7 +16,7 @@ module.exports = {
     },
     sourceType: 'module',
   },
-  plugins: ['react', 'prettier'],
+  plugins: ['jest', 'react', 'prettier'],
   rules: {
     'prettier/prettier': 'error',
     'react/prop-types': [0],
@@ -26,9 +26,9 @@ module.exports = {
     'no-unreachable': 'error',
     'no-unused-vars': [
       'error',
-      {varsIgnorePattern: '^_', args: 'all', argsIgnorePattern: '^_'},
+      { varsIgnorePattern: '^_', args: 'all', argsIgnorePattern: '^_' },
     ],
     'constructor-super': 'error',
     'valid-typeof': 'error',
   },
-};
+}

.stylelintrc.js

@@ -1,4 +1,5 @@
 module.exports = {
+  extends: ['stylelint-config-standard', 'stylelint-config-prettier'],
   plugins: ['stylelint-prettier'],
   rules: {
     'prettier/prettier': true,

package.json

@@ -38,6 +38,7 @@
     "babel-eslint": "^10.0.1",
     "babel-jest": "^23.6.0",
     "eslint": "^5.8.0",
+    "eslint-config-prettier": "^3.1.0",
     "eslint-plugin-jest": "^21.27.1",
     "eslint-plugin-prettier": "^3.0.0",
     "eslint-plugin-react": "^7.11.1",
@@ -46,6 +47,8 @@
     "lerna": "^3.4.3",
     "prettier": "^1.14.3",
     "stylelint": "^9.7.1",
+    "stylelint-config-prettier": "^4.0.0",
+    "stylelint-config-standard": "^18.2.0",
     "stylelint-prettier": "^1.0.3",
     "web-ext": "^2.4.0"
   }

packages/browser-webdriver/src/shims/fs.js

@@ -16,7 +16,6 @@
 // under the License.
 
 const fs = require('fs')
-fs.existsSync = file => {
-  console.log('fs.existsSync: ' + file)
+fs.existsSync = _file => {
   return false
 }

packages/selenium-ide/src/neo/IO/SideeX/recorder.js

@@ -79,7 +79,6 @@ export default class BackgroundRecorder {
 
   // TODO: rename method
   tabsOnActivatedHandler(activeInfo) {
-    console.log('tabs.onActivated')
     this.lastActivatedTabId = activeInfo.tabId
     let testCase = getSelectedCase()
     if (!testCase) {
@@ -130,7 +129,6 @@ export default class BackgroundRecorder {
   }
 
   windowsOnFocusChangedHandler(windowId) {
-    console.log('windows.onFocusChanged')
     let testCase = getSelectedCase()
     if (!testCase) {
       return
@@ -206,7 +204,6 @@ export default class BackgroundRecorder {
 
   tabsOnRemovedHandler(tabId, _removeInfo) {
     // eslint-disable-line no-unused-vars
-    console.log('tabs.onRemoved')
     let testCase = getSelectedCase()
     if (!testCase) {
       return
@@ -254,7 +251,6 @@ export default class BackgroundRecorder {
   webNavigationOnCreatedNavigationTargetHandler(details) {
     // we can't necessarily know that this will indicate a tab being
     // activated, and we hope tabs.onActivated will get called for us
-    console.log('webNavigation.OnCreatedNavigationTarget')
     let testCase = getSelectedCase()
     if (!testCase) return
     let testCaseId = testCase.id

packages/selenium-ide/src/plugin/manager.js

@@ -46,8 +46,7 @@ class PluginManager {
       return new Promise(res => {
         Promise.all(
           this.plugins.map(plugin =>
-            this.emitConfiguration(plugin, project).catch(e => {
-              console.log(e)
+            this.emitConfiguration(plugin, project).catch(_e => {
               return ''
             })
           )

packages/selenium-side-runner/src/index.js

@@ -283,7 +283,7 @@ function runJest(project) {
     const child = fork(require.resolve('./child'), args, opts)
 
     child.on('exit', code => {
-      console.log('')
+      console.log('') // eslint-disable-line no-console
       if (!program.run) {
         rimraf.sync(projectPath)
       }

yarn.lock

@@ -2699,6 +2699,13 @@ escope@^3.6.0:
     esrecurse "^4.1.0"
     estraverse "^4.1.1"
 
+eslint-config-prettier@^3.1.0:
+  version "3.1.0"
+  resolved "https://registry.yarnpkg.com/eslint-config-prettier/-/eslint-config-prettier-3.1.0.tgz#2c26d2cdcfa3a05f0642cd7e6e4ef3316cdabfa2"
+  integrity sha512-QYGfmzuc4q4J6XIhlp8vRKdI/fI0tQfQPy1dME3UOLprE+v4ssH/3W9LM2Q7h5qBcy5m0ehCrBDU2YF8q6OY8w==
+  dependencies:
+    get-stdin "^6.0.0"
+
 eslint-plugin-jest@^21.27.1:
   version "21.27.1"
   resolved "https://registry.yarnpkg.com/eslint-plugin-jest/-/eslint-plugin-jest-21.27.1.tgz#b64c2d6a7f0751cecc14580d7f4d9a5520424448"
@@ -7854,6 +7861,23 @@ style-search@^0.1.0:
   version "0.1.0"
   resolved "https://registry.yarnpkg.com/style-search/-/style-search-0.1.0.tgz#7958c793e47e32e07d2b5cafe5c0bf8e12e77902"
 
+stylelint-config-prettier@^4.0.0:
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/stylelint-config-prettier/-/stylelint-config-prettier-4.0.0.tgz#8c712977be13bd25191ab8b986b5c07a3342a5dc"
+  integrity sha512-cwh3QbBC2+3zBeMvuxFjT8XsbSdyoyELOY9BZqMuvphUKEQ+srkPWoN60FlvRwLB014TOke4Y12KvTtfKnaHhg==
+
+stylelint-config-recommended@^2.1.0:
+  version "2.1.0"
+  resolved "https://registry.yarnpkg.com/stylelint-config-recommended/-/stylelint-config-recommended-2.1.0.tgz#f526d5c771c6811186d9eaedbed02195fee30858"
+  integrity sha512-ajMbivOD7JxdsnlS5945KYhvt7L/HwN6YeYF2BH6kE4UCLJR0YvXMf+2j7nQpJyYLZx9uZzU5G1ZOSBiWAc6yA==
+
+stylelint-config-standard@^18.2.0:
+  version "18.2.0"
+  resolved "https://registry.yarnpkg.com/stylelint-config-standard/-/stylelint-config-standard-18.2.0.tgz#6283149aba7f64f18731aef8f0abfb35cf619e06"
+  integrity sha512-07x0TaSIzvXlbOioUU4ORkCIM07kyIuojkbSVCyFWNVgXMXYHfhnQSCkqu+oHWJf3YADAnPGWzdJ53NxkoJ7RA==
+  dependencies:
+    stylelint-config-recommended "^2.1.0"
+
 stylelint-prettier@^1.0.3:
   version "1.0.3"
   resolved "https://registry.yarnpkg.com/stylelint-prettier/-/stylelint-prettier-1.0.3.tgz#d7b1e8c331045dc1fd9d792dd8a1a5afc5304018"