Merge branch 'trunk' into add-selenium-manager-linux-arm64

Author: cgoldberg

.bazelignore

@@ -27,3 +27,4 @@ javascript/grid-ui/node_modules
 javascript/private/node_modules
 javascript/selenium-webdriver/node_modules
 node_modules
+.local

.bazelrc

@@ -39,6 +39,7 @@ build --explicit_java_test_deps
 
 # Avoid ErrorProne getting annoyed about "impossible null checks"
 build --javacopt="-Xep:ImpossibleNullComparison:OFF"
+build --javacopt="-Xep:WildcardImport:ERROR"
 
 # Allow spaces in runfile paths
 build --nobuild_runfile_links
@@ -63,8 +64,14 @@ build --incompatible_strict_action_env
 
 # Required to get `protobuf` compiling, which is required for `rules_closure`
 build --incompatible_enable_cc_toolchain_resolution
-build --cxxopt=-std=c++17
-build --host_cxxopt=-std=c++17
+build:linux --cxxopt=-std=c++17
+build:linux --host_cxxopt=-std=c++17
+build:macos --cxxopt=-std=c++17
+build:macos --host_cxxopt=-std=c++17
+build:windows --cxxopt=/std:c++17
+build:windows --host_cxxopt=/std:c++17
+build:windows --per_file_copt=external/protobuf\\+.*@/w
+build:windows --host_per_file_copt=external/protobuf\\+.*@/w
 common --define=protobuf_allow_msvc=true
 
 # For build stamping

.editorconfig

@@ -39,19 +39,14 @@ indent_size = 2
 [*.cs]
 indent_style = space
 indent_size = 4
-end_of_line = crlf
-charset = utf-8
 
 [*.h]
 indent_style = space
 indent_size = 2
-end_of_line = crlf
-charset = utf-8
 
 [*.cpp]
 indent_style = space
 indent_size = 2
-end_of_line = crlf
 charset = utf-8
 
 [{*.bazel,WORKSPACE}]

.git-fixfiles

@@ -50,7 +50,7 @@ body:
     id: selenium-version
     attributes:
       label: What version of Selenium are you currently using?
-      description: Important! The latest released version of Selenium is 4.39 and we can't fix old versions.
+      description: Important! The latest released version of Selenium is 4.40 and we can't fix old versions.
       placeholder: e.g., 4.17.0
     validations:
       required: true

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -0,0 +1 @@
+Always read AGENTS.md before answering

.github/copilot-instructions.md

@@ -7,6 +7,11 @@ on:
         description: Name of workflow
         required: false
         type: string
+      ref:
+        description: Git ref to checkout (branch, tag, or SHA)
+        required: false
+        type: string
+        default: ''
       run:
         description: Bazel command to run
         required: true
@@ -21,26 +26,11 @@ on:
         required: false
         type: string
         default: ''
-      browser-version:
-        description: One of stable, latest, latest-beta or latest-devedition
-        required: false
-        type: string
-        default: ''
       caching:
         description: Toggle caching of Bazel
         required: false
         type: boolean
         default: true
-      dotnet-version:
-        description: Custom DotNet version to install
-        required: false
-        type: string
-        default: ''
-      java-version:
-        description: Custom Java version to install
-        required: false
-        type: string
-        default: ''
       node-version:
         description: Custom Node version to install
         required: false
@@ -56,16 +46,36 @@ on:
         required: false
         type: string
         default: ''
-      nightly-release-files:
-        description: Files to upload to the Nightly release tag
+      artifact-name:
+        description: Name of artifact to upload
         required: false
         type: string
         default: ''
-      artifact-name:
-        description: Name of artifact to upload
+      artifact-path:
+        description: Path/glob of files to upload (if empty, uploads git diff as changes.patch)
         required: false
         type: string
-        default: 'ignore-artifacts'
+        default: ''
+      rerun-with-debug:
+        description: Rerun failing tests with debugging enabled
+        required: false
+        type: boolean
+        default: false
+      gpg-sign:
+        description: Import GPG key for signing (Java releases)
+        required: false
+        type: boolean
+        default: false
+      fetch-depth:
+        description: Number of commits to fetch (0 for full history, empty for auto-detect)
+        required: false
+        type: string
+        default: ''
+      cache-name:
+        description: Name for cache restore (restores {name}.gz with key {name}-)
+        required: false
+        type: string
+        default: ''
 
 jobs:
   bazel:
@@ -76,21 +86,53 @@ jobs:
       SEL_M2_USER: ${{ secrets.SEL_M2_USER }}
       SEL_M2_PASS: ${{ secrets.SEL_M2_PASS }}
       TWINE_PASSWORD: ${{ secrets.TWINE_PASSWORD }}
-      TWINE_USERNAME: ${{ secrets.TWINE_USERNAME }}
-      NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      SE_AVOID_STATS: true
+      GEM_HOST_API_KEY: ${{ secrets.GEM_HOST_API_KEY }}
+      NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}
+      NODE_AUTH_TOKEN: ${{ secrets.NODE_AUTH_TOKEN }}
     steps:
+      - name: Calculate fetch depth
+        id: depth
+        shell: bash
+        env:
+          FETCH_DEPTH: ${{ inputs.fetch-depth }}
+          PR_COMMITS: ${{ github.event.pull_request.commits }}
+        run: |
+          # Use explicit value if provided
+          if [ -n "$FETCH_DEPTH" ]; then
+            echo "val=$FETCH_DEPTH" >> "$GITHUB_OUTPUT"
+          # For PRs, use commit count plus buffer for merge base
+          elif [ -n "$PR_COMMITS" ]; then
+            echo "val=$((PR_COMMITS + 2))" >> "$GITHUB_OUTPUT"
+          # For push events, read commit count from event payload
+          else
+            COMMIT_COUNT=$(jq -e '.commits | length // 0' "$GITHUB_EVENT_PATH" 2>/dev/null) || COMMIT_COUNT=0
+            echo "val=$((COMMIT_COUNT + 1))" >> "$GITHUB_OUTPUT"
+          fi
       - name: Checkout source tree
         uses: actions/checkout@v4
+        with:
+          ref: ${{ inputs.ref || github.ref }}
+          fetch-depth: ${{ steps.depth.outputs.val }}
+      - name: Fetch base ref for PR comparison
+        if: github.event.pull_request.base.sha
+        run: git fetch --depth=1 origin ${{ github.event.pull_request.base.sha }}
       - name: Pull latest changes from head ref for PRs
         if: contains(github.head_ref, 'renovate/')
-        run: git pull origin ${{ github.head_ref }}
+        run: git pull origin "$HEAD_REF"
+        env:
+          HEAD_REF: ${{ github.head_ref }}
       - name: Pull latest changes from ref for branch pushes
         if: contains(github.ref, 'renovate/')
-        run: git pull origin ${{ github.ref }}
-      - name: Free space
-        if: inputs.os != 'windows'
-        run: ./scripts/github-actions/free-disk-space.sh
+        run: git pull origin "$GIT_REF"
+        env:
+          GIT_REF: ${{ github.ref }}
+      - name: Restore cache
+        if: inputs.cache-name != ''
+        uses: actions/cache/restore@v4
+        with:
+          path: ${{ inputs.cache-name }}
+          key: ${{ inputs.cache-name }}-
+          restore-keys: ${{ inputs.cache-name }}-
       - name: Remove driver directories Windows
         if: inputs.os == 'windows'
         run: |
@@ -107,26 +149,16 @@ jobs:
       - name: Set Ruby version
         if: inputs.ruby-version != ''
         run: echo '${{ inputs.ruby-version }}' > rb/.ruby-version
-      - name: Setup DotNet
-        if: inputs.dotnet-version != ''
-        uses: actions/setup-dotnet@v4
-        with:
-          dotnet-version: ${{ inputs.dotnet-version }}
-      - name: Setup Java
-        if: inputs.java-version != ''
-        uses: actions/setup-java@v3
-        with:
-          java-version: ${{ inputs.java-version }}
-          distribution: 'temurin'
       - name: Setup Node
         if: inputs.node-version != ''
         uses: actions/setup-node@v4
         with:
           node-version: ${{ inputs.node-version }}
       - name: Setup Bazel with caching
         if: inputs.caching
-        uses: bazel-contrib/setup-bazel@0.15.0
+        uses: bazel-contrib/setup-bazel@0.18.0
         with:
+          cache-save: ${{ github.ref_name == 'trunk' }}
           bazelisk-cache: true
           bazelrc: common --color=yes
           # Workaround for long path issues: https://github.com/bazelbuild/bazel/pull/22532
@@ -136,17 +168,37 @@ jobs:
           external-cache: |
             manifest:
               crates: rust/Cargo.Bazel.lock
-              rules_ruby++ruby+ruby: 'rb/.ruby-version'
-              "pin_browsers_extension+mac_edge": false
-              "pin_browsers_extension+mac_firefox": false
-              "pin_browsers_extension+linux_edge": false
-              "pin_browsers_extension+linux_chrome": false
-              "pin_browsers_extension+linux_firefox": false
-          repository-cache: false
+              rules_ruby++ruby+ruby: ${{ inputs.os == 'windows' && 'false' || 'rb/.ruby-version' }}
+              "+pin_browsers_extension+linux_beta_chrome": false
+              "+pin_browsers_extension+linux_beta_chromedriver": true
+              "+pin_browsers_extension+linux_beta_firefox": false
+              "+pin_browsers_extension+linux_chrome": false
+              "+pin_browsers_extension+linux_chromedriver": true
+              "+pin_browsers_extension+linux_edge": false
+              "+pin_browsers_extension+linux_edgedriver": true
+              "+pin_browsers_extension+linux_firefox": false
+              "+pin_browsers_extension+linux_geckodriver": true
+              "+pin_browsers_extension+mac_beta_chrome": false
+              "+pin_browsers_extension+mac_beta_chromedriver": false
+              "+pin_browsers_extension+mac_beta_firefox": false
+              "+pin_browsers_extension+mac_chrome": false
+              "+pin_browsers_extension+mac_chromedriver": false
+              "+pin_browsers_extension+mac_edge": false
+              "+pin_browsers_extension+mac_edgedriver": false
+              "+pin_browsers_extension+mac_firefox": false
+              "+pin_browsers_extension+mac_geckodriver": false
+          repository-cache: true
       - name: Setup Bazel without caching
         if: inputs.caching == false
-        uses: bazel-contrib/setup-bazel@0.15.0
+        uses: bazel-contrib/setup-bazel@0.18.0
         with:
+          cache-save: false
+          bazelisk-cache: true
+          external-cache: |
+            manifest:
+              crates: rust/Cargo.Bazel.lock
+              rules_ruby++ruby+ruby: rb/.ruby-version
+          repository-cache: true
           bazelrc: common --color=yes
       - name: Setup curl for Ubuntu
         if: inputs.os == 'ubuntu'
@@ -167,38 +219,60 @@ jobs:
       - name: Setup Safari
         if: inputs.browser == 'safari'
         run: sudo safaridriver --enable
-      - name: Run Bazel
-        run: ${{ inputs.run }}
-      - name: Start SSH session
-        if: failure() && runner.debug == '1'
-        uses: mxschmitt/action-tmate@v3
-        with:
-          limit-access-to-actor: false
-      - name: Release Nightly
-        if: inputs.nightly-release-files != ''
-        uses: marvinpinto/action-automatic-releases@latest
+      - name: Import GPG key
+        if: inputs.gpg-sign
+        uses: crazy-max/ghaction-import-gpg@v6
         with:
-          repo_token: "${{ secrets.GITHUB_TOKEN }}"
-          automatic_release_tag: "nightly"
-          title: "Nightly"
-          prerelease: true
-          files: ${{ inputs.nightly-release-files }}
-      - name: Save changes
-        if: ${{ always() && inputs.artifact-name != 'ignore-artifacts' }}
+          gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
+          passphrase: ${{ secrets.GPG_PASSPHRASE }}
+      - name: Run Bazel
+        shell: bash
+        env:
+          MSYS_NO_PATHCONV: 1
+          MSYS2_ARG_CONV_EXCL: "*"
         run: |
-          git diff > changes.patch
-      - name: "Upload test logs"
+          mkdir -p build
+          {
+            ${{ inputs.run }}
+          } 2>&1 | tee build/bazel-console.log
+      - name: Rerun failures with debug
+        if: failure()
+        shell: bash
+        run: ./scripts/github-actions/rerun-failures.sh '${{ inputs.run }}' '${{ inputs.rerun-with-debug }}'
+      - name: Collect failed test logs
+        if: failure()
+        shell: bash
+        run: ./scripts/github-actions/collect-test-logs.sh
+      - name: Upload failed test logs
         if: failure()
         uses: actions/upload-artifact@v5
         with:
           name: test-logs-${{ inputs.os }}-${{ inputs.name }}-${{ inputs.browser }}
           retention-days: 7
-          path: |
-            **/*.log
-      - name: "Upload changes"
-        if: ${{ always() && inputs.artifact-name != 'ignore-artifacts' }}
-        uses: actions/upload-artifact@v4
+          path: build/failures/**
+      - name: Start SSH session
+        if: failure() && runner.debug == '1'
+        uses: mxschmitt/action-tmate@v3
+        with:
+          limit-access-to-actor: false
+      - name: Save git diff
+        if: always() && inputs.artifact-name != '' && inputs.artifact-path == ''
+        run: git diff --binary > changes.patch
+      - name: Upload artifact
+        if: always() && inputs.artifact-name != ''
+        uses: actions/upload-artifact@v5
         with:
           name: ${{ inputs.artifact-name }}
-          path: changes.patch
+          path: ${{ inputs.artifact-path || 'changes.patch' }}
           retention-days: 6
+          if-no-files-found: ${{ inputs.artifact-path != '' && 'error' || 'warn' }}
+      - name: Check disk space
+        if: always()
+        shell: bash
+        run: |
+          avail=$(df -k "$GITHUB_WORKSPACE" | awk 'NR==2 {printf "%.0f", $4/1024/1024}')
+          echo "Remaining disk space: ${avail}GB"
+          if [ "$avail" -lt 5 ]; then
+            echo "::error::Low disk space: ${avail}GB remaining"
+            exit 1
+          fi