Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: [dotnet] [bidi] Don't throw exception when CallFunction/Evaluate in Script module #15414

Open
nvborisenko opened this issue Mar 13, 2025 · 1 comment

Comments

@nvborisenko
Copy link
Member

Feature and motivation

await context.Script.CallFunctionAsync("() => { return ['hi']; }", false);

It throws an .Net exception rather than returning EvaluateResult BiDi object.

script.EvaluateResult = (
  script.EvaluateResultSuccess /
  script.EvaluateResultException
)

Now, .Net methods throw if the result is EvaluateResultException. It is not ideal, low-level binding should not introduce additional logic on top of specification.

Why:

  • We are hiding all data included into EvaluateResultException, trying to include it in .Net Exception type.
  • If in future new derived type will be introduced in the spec (like "PartiallySuccess"), then we will be in **s (problematic situation)

Usage example

Before:

public Task<EvaluateResult.Success> CallFunctionAsync(...)

After:

public Task<EvaluateResult> CallFunctionAsync(...)

NOTE: Keeping in mind implicit/explicit type conversions in .NET.

Copy link

@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant