-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[py] Fix possible TypeError in expected conditions #15891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] Fix possible TypeError in expected conditions #15891
Conversation
Thank you, @ShauryaDusht for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
PR Code Suggestions ✨No code suggestions found for the PR. |
PR Code Suggestions ✨No code suggestions found for the PR. |
This is more of a bug fix and doesn't address any type issues, right? |
Yes, it is a bug fix Also, I wanted to ask do changes in this file appear |
Your branch doesn't contain the changes to |
Figured it out.. You already made the change to So when I merged trunk into your branch, that was already there. Please update this PR title and description to reflect the current changes. |
I have updated the title and description. Thanks! |
I updated your PR title and description. This is just a bug fix, not an adjustment to type hints. |
Thanks for the clarification and updating the title/description. |
💥 What does this PR do?
Fixes possible
TypeError
intext_to_be_present_in_element_value
inpy/selenium/webdriver/support/expected_conditions.py
. This could occur ifget_attribute
returnsNone
.🔄 Types of changes
PR Type
Bug fix
Description
• Add null check for element text attribute