-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Closed as not planned
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!C-javaJava BindingsJava BindingsI-enhancementSomething could be betterSomething could be better
Description
Description
selenium-support
brings the complete guava library as a dependency however it is only used in 2 places:
public interface ExpectedCondition<T> extends Function<WebDriver, T>, java.util.function.Function<WebDriver, T> {} - Recommended action: Remove the guava interface completely. This was relevant 14 years ago, however since Java 8 (released 11 years ago) we already Java's
Function
which does the same job
- Recommended action: Remove the guava interface completely. This was relevant 14 years ago, however since Java 8 (released 11 years ago) we already Java's
import com.google.common.base.Joiner; - Recommended action: This can be replaced using the Java Streaming API. Example:
return "at least one condition to be valid: " + Arrays.stream(conditions) .filter(Objects::nonNull) .map(Object::toString) .collect(Collectors.joining(" || "));
- Recommended action: This can be replaced using the Java Streaming API. Example:
Does this apply to specific language bindings?
Java
Metadata
Metadata
Assignees
Labels
A-needs-triagingA Selenium member will evaluate this soon!A Selenium member will evaluate this soon!C-javaJava BindingsJava BindingsI-enhancementSomething could be betterSomething could be better