-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Range input or slider #3384
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
I would love to see a range component added as well. Right now, the path for adding components is a little tough since we need to add them to both Semantic UI (jQuery) and Semantic UI React. The best way to get this added for now is to get it merged to Semantic UI core, then we can add the port here in Semantic UI React. I'm working on ways for sharing state, styles, and accessibility between the frameworks. Once we have this, we can have a central place for adding components like this. |
Okay, sounds good. So if I understand correctly, firstly we need to implement slider for Semantic UI core, using jQuery. Do you already have some code for this, or need to develop from scratch? Can I help with that? |
I found that issue, so I'll take a look more tomorrow |
@levithomason What is the current status? As I can see @gdaunton already implemented everything on jQuery, and created PR's to core, but then it'll be closed because... it was been ignored? So what is the plan? |
@alexandrtovmach Not sure if SUIR team has it maybe already under discussion, but there actually is a Slider component in Fomantic UI, which is a fork of Semantic UI core created to continue its active development. Due to lack of Slider component in Semantic UI React I had to blend its Fomantic's jQuery implementation into my React application. @levithomason Is Semantic UI React team maybe considering an option to switch to Fomantic UI as a base in future? |
I second the notion to use Fomantic UI fork. Not only as an option but as the actual base for this project. Reason being that the folks behind the Fomantic fork actually intend to merge with Semantic once active development there picks up again (Well that's the plan at least...) There are lot's of benefits to be gained:
The bulk of the work for such a feat would come in the form of new component implementation and replacing the jQuery stuff with React. Also implementing new features on existing components, like the clear able option for the drop down. Mostly in the form of new properties. I'd hate to see a Fomantic-UI-React fork as well since this repo is far from being stale. However the current state of affairs simply limit future progress considering that the code (LESS, JQuery) already exists over at Fomantic. |
I'm afraid that is no longer true: |
@transfer1992 @SuchMonkey SUIR switching to FUI has already been discussed here #3397 @transfer1992 I don't want to take this issue off-topic so I will keep it brief but FUI does still have the intention to merge back into SUI but under different circumstances. If you want to read more I just posted a comment here |
@alexandrtovmach Hi, may I ask why you closed the issue? I think the need for this is still there, or am I wrong? |
@CarlQLange in reason of no any progress, and seems like it'll be never realized Semantic UI is stopped active development of new features, so this issue haven't any sense |
Hey folks...it's from 2019. |
Implement range input component (slider)
I've discovered what Semantic UI haven't any slider soluitions.
After some research I found separate package react-semantic-ui-range for react, which is actually based on semantic-ui-range, but why does Semantic not have something like this "inside the box"?
I would be happy to create this, or maybe colaborate with someone
I want to create this component from scratch, because I'm not sure that it'll be fair to use codebase above. The authors of these packages didn't create any PR's for Semantic UI repo, therefore, probably, they do not want to cooperate with them.
The main reason for this ticket is to understand:
The text was updated successfully, but these errors were encountered: