Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range input or slider #3384

Closed
alexandrtovmach opened this issue Jan 17, 2019 · 12 comments
Closed

Range input or slider #3384

alexandrtovmach opened this issue Jan 17, 2019 · 12 comments

Comments

@alexandrtovmach
Copy link

Implement range input component (slider)

I've discovered what Semantic UI haven't any slider soluitions.

After some research I found separate package react-semantic-ui-range for react, which is actually based on semantic-ui-range, but why does Semantic not have something like this "inside the box"?

I would be happy to create this, or maybe colaborate with someone

I want to create this component from scratch, because I'm not sure that it'll be fair to use codebase above. The authors of these packages didn't create any PR's for Semantic UI repo, therefore, probably, they do not want to cooperate with them.

The main reason for this ticket is to understand:

“Do we need to have a slider inside the Semantic UI, or better to continue using a third-party solution?”

@welcome
Copy link

welcome bot commented Jan 17, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@levithomason
Copy link
Member

levithomason commented Jan 17, 2019

I would love to see a range component added as well. Right now, the path for adding components is a little tough since we need to add them to both Semantic UI (jQuery) and Semantic UI React.

The best way to get this added for now is to get it merged to Semantic UI core, then we can add the port here in Semantic UI React.

I'm working on ways for sharing state, styles, and accessibility between the frameworks. Once we have this, we can have a central place for adding components like this.

@alexandrtovmach
Copy link
Author

Okay, sounds good. So if I understand correctly, firstly we need to implement slider for Semantic UI core, using jQuery. Do you already have some code for this, or need to develop from scratch? Can I help with that?

@alexandrtovmach
Copy link
Author

I found that issue, so I'll take a look more tomorrow

@alexandrtovmach
Copy link
Author

@levithomason What is the current status? As I can see @gdaunton already implemented everything on jQuery, and created PR's to core, but then it'll be closed because... it was been ignored? So what is the plan?

@transfer1992
Copy link

transfer1992 commented Jan 31, 2019

@alexandrtovmach Not sure if SUIR team has it maybe already under discussion, but there actually is a Slider component in Fomantic UI, which is a fork of Semantic UI core created to continue its active development. Due to lack of Slider component in Semantic UI React I had to blend its Fomantic's jQuery implementation into my React application. @levithomason Is Semantic UI React team maybe considering an option to switch to Fomantic UI as a base in future?

@SuchMonkey
Copy link

I second the notion to use Fomantic UI fork. Not only as an option but as the actual base for this project. Reason being that the folks behind the Fomantic fork actually intend to merge with Semantic once active development there picks up again (Well that's the plan at least...)

There are lot's of benefits to be gained:

  • Various bug fixes
  • New components like the after mentioned range slider but also a date picker, placeholder segments and recently global text colors
  • Active development

The bulk of the work for such a feat would come in the form of new component implementation and replacing the jQuery stuff with React. Also implementing new features on existing components, like the clear able option for the drop down. Mostly in the form of new properties.
The bug fixes mainly concern the CSS / LESS.

I'd hate to see a Fomantic-UI-React fork as well since this repo is far from being stale. However the current state of affairs simply limit future progress considering that the code (LESS, JQuery) already exists over at Fomantic.

@transfer1992
Copy link

Reason being that the folks behind the Fomantic fork actually intend to merge with Semantic once active development there picks up again (Well that's the plan at least...)

I'm afraid that is no longer true:
fomantic/Fomantic-UI#319 (comment)

@y0hami
Copy link
Member

y0hami commented Feb 8, 2019

@transfer1992 @SuchMonkey SUIR switching to FUI has already been discussed here #3397

@transfer1992 I don't want to take this issue off-topic so I will keep it brief but FUI does still have the intention to merge back into SUI but under different circumstances. If you want to read more I just posted a comment here

@CarlQLange
Copy link

@alexandrtovmach Hi, may I ask why you closed the issue? I think the need for this is still there, or am I wrong?

@alexandrtovmach
Copy link
Author

alexandrtovmach commented Jul 10, 2019

@CarlQLange in reason of no any progress, and seems like it'll be never realized

Semantic UI is stopped active development of new features, so this issue haven't any sense

@felipenmoura
Copy link

Hey folks...it's from 2019.
No merge from FUI into SUI that could bring such feature?
A range/slider is simply a "must have" for any interface library :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants