Move reflection out of SorterBuilderKeyIterator

Author: SenseException

src/DependencyInjection/CompilerPass/SorterBuilderKeyIterator.php

@@ -6,7 +6,6 @@
 
 use ArrayIterator;
 use FilterIterator;
-use ReflectionClass;
 use ReflectionMethod;
 
 use function assert;
@@ -19,20 +18,10 @@
  * @template TKey
  * @template T
  * @template TIterator as ArrayIterator<int, ReflectionMethod>
- *
  * @extends FilterIterator<TKey, T, TIterator>
  */
 class SorterBuilderKeyIterator extends FilterIterator
 {
-    /** @phpstan-param class-string $className */
-    public function __construct(string $className)
-    {
-        $reflectionClass = new ReflectionClass($className);
-        $methods         = $reflectionClass->getMethods(ReflectionMethod::IS_PUBLIC);
-
-        parent::__construct(new ArrayIterator($methods));
-    }
-
     public function accept(): bool
     {
         return ! in_array($this->current(), [

src/DependencyInjection/Configuration.php

@@ -4,8 +4,11 @@
 
 namespace Budgegeria\Bundle\IntlBundle\DependencyInjection;
 
+use ArrayIterator;
 use Budgegeria\Bundle\IntlBundle\DependencyInjection\CompilerPass\SorterBuilderKeyIterator;
 use Budgegeria\IntlSort\Builder;
+use ReflectionClass;
+use ReflectionMethod;
 use Symfony\Component\Config\Definition\Builder\NodeDefinition;
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
@@ -39,7 +42,8 @@ private function buildSorter(NodeDefinition $node): void
             ->arrayPrototype()
             ->children();
 
-        foreach (new SorterBuilderKeyIterator(Builder::class) as $sorterConfigNames) {
+        $methods = new ArrayIterator($this->getClassMethods(Builder::class));
+        foreach (new SorterBuilderKeyIterator($methods) as $sorterConfigNames) {
             $sorterChildren->scalarNode($sorterConfigNames)->end();
         }
 
@@ -50,4 +54,16 @@ private function buildSorter(NodeDefinition $node): void
             ->end()
             ->end();
     }
+
+    /**
+     * @phpstan-param class-string $className
+     *
+     * @phpstan-return list<ReflectionMethod>
+     */
+    private function getClassMethods(string $className): array
+    {
+        $reflectionClass = new ReflectionClass($className);
+
+        return $reflectionClass->getMethods(ReflectionMethod::IS_PUBLIC);
+    }
 }

tests/DependencyInjection/CompilerPass/SorterBuilderKeyIteratorTest.php

@@ -4,9 +4,12 @@
 
 namespace Budgegeria\Bundle\IntlBundle\Tests\DependencyInjection\CompilerPass;
 
+use ArrayIterator;
 use Budgegeria\Bundle\IntlBundle\DependencyInjection\CompilerPass\SorterBuilderKeyIterator;
 use Budgegeria\IntlSort\Builder;
 use PHPUnit\Framework\TestCase;
+use ReflectionClass;
+use ReflectionMethod;
 
 use function array_values;
 use function iterator_to_array;
@@ -15,7 +18,9 @@ class SorterBuilderKeyIteratorTest extends TestCase
 {
     public function testIterationContent(): void
     {
-        $sorterKeys = iterator_to_array(new SorterBuilderKeyIterator(Builder::class));
+        $sorterKeys = iterator_to_array(new SorterBuilderKeyIterator(
+            new ArrayIterator($this->getMethods(Builder::class)),
+        ));
         $expected   = [
             'enable_french_collation',
             'disable_french_collation',
@@ -48,4 +53,16 @@ public function testIterationContent(): void
 
         self::assertEquals($expected, array_values($sorterKeys));
     }
+
+    /**
+     * @phpstan-param class-string $className
+     *
+     * @phpstan-return list<ReflectionMethod>
+     */
+    private function getMethods(string $className): array
+    {
+        $reflectionClass = new ReflectionClass($className);
+
+        return $reflectionClass->getMethods(ReflectionMethod::IS_PUBLIC);
+    }
 }