[Bug]: click/tap method is not working in release 8.4.20241024

[mabouamer-93]

Describe the bug

click/tap method is not working and throwing Method is not implemented error

Link to SHAFT_Engine Console logs

https://gist.github.com/mabouamer-93/a0ca86158702d6b0d9351a46d6dc051e

Environment

1. SHAFT_Engine version that exhibits the issue (8.4.20241024):
2. Last SHAFT_Engine version that did not exhibit the issue (8.3.20240829):
3. Desktop OS: [Mac OS 15.2]
4. Mobile Device Name [iPhone 15 Pro Max]
5. Mobile Device OS [iOS 18.2]

To Reproduce

Steps to reproduce the behavior:

1. driver.element().click() OR driver.touch().tap()

Expected behavior

driver clicked/taped on the element

[MohabMohie]

Attached logs show that SHAFT's forced scrolling using JavaScript is breaking click and tap actions against non-w3c-compliant appium scripts.

SHAFT should disable automated scrolling in case of non-web executions.

[MohabMohie]

Further investigation shows that the user is configuring shaft for fullpage screenshots (which is the default configuration). This is why scrolling is called and why it fails.

The root cause behind it is that SHAFT is trying to get the element name (per default configuration) using the text attribute which should be replaced by the name attribute in case of appium execution.

Shaft should force regular screenshots instead of full page screenshots in case of appium execution.

Shaft should call the name attribute in case of appium execution.

[MohabMohie]

First fix implemented. Shaft will now call the "name" attribute for appium elements and the "text" attribute for web elements.

Second fix seems to be already in place. Shaft will override screenshot type with VIEWPORT to prevent taking a fullpage screenshot on mobile devices. Further investigation is needed on a newer SHAFT release.

SHAFT_ENGINE/src/main/java/com/shaft/properties/internal/PropertiesHelper.java

Line 118 in 5cc38ef

private static void overrideScreenShotTypeForMobileAndMacPlatforms() {