-
Notifications
You must be signed in to change notification settings - Fork 1k
SPFx 1.21 RC changes location of manifest.js #10193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related: #10053 |
Hello @jhholm , |
Hello @jhholm , |
@Amey-MSFT - Just to be clear - @nick-pape from the SPFx engineering side is currently looking into this and we might change the locations back. So let's not confirm any changes and ask ecosystem to do updates until we have the situation fully confirmed with the owning engineering team. |
Hello @jhholm , |
Hi, |
It seems that the SharePoint Framework Hosted Workbench (_layouts/15/workbench.aspx) is trying to load from both locations. Is this functionality going to stay there, or can we expect older versions of SPFx to be "deprecated" at some point? |
@jhholm - to ensure that the online workbench works with all versions, it will keep on continuing supporting all locations. Technically we still support even SPFx v1.0 in the workbench and no plans to do breaking changes for customers and partners on that. with the 1.21 - there's a known issue on the workbench wrongly showing a message that the localhost is not connected - even though web part will be in the picker. This will be addressed with server side fix in upcoming days/week(s) as the update will rollout in the hosting platform. Closing this as answered - by design with 1.21 with the underlaying package changes. Not quite optimal due the impact on the open-source tooling, but was informed that there are no further work to be done in here. |
Uh oh!
There was an error while loading. Please reload this page.
What type of issue is this?
Question
What SharePoint development model, framework, SDK or API is this about?
💥 SharePoint Framework
Target SharePoint environment
SharePoint Online
What browser(s) / client(s) have you tested
Additional environment details
No response
Issue description
Running SPFx local development with gulp serve has a small change introduced with 1.21-beta.2. The location of manifest.js has changed from temp/manifest.js to temp/build/manifest.js. So the URL to load debug scripts manually is different from prior versions and this is shown in the task log seen below.
Until 1.21-beta.2
Since 1.21-beta.2
This most definately is a nitpick, but this change will cause a breaking change with spfx-fast-serve. That can be easily handled as it's a versioned dependency, so no issue there.
This will also affect sp-editor which has a button to load the debug manifest. The location of the manifest.js will be different depending on the spfx version.
Additionally I guess some people have their own scripts that could break. I do understand things need to change, but I wanted to ask if this change was intentional?
The text was updated successfully, but these errors were encountered: